[ekiga] Fixed LLVM/CLANG reports

[Julien Puydt <jpuydt src gnome org>]

commit 2b96e33d586836655c66f235ddba28d18bfd26ed
Author: Julien Puydt <jpuydt cauchy localdomain>
Date:   Mon Apr 14 20:21:48 2014 +0200

    Fixed LLVM/CLANG reports
    
    Thanks John Smith for pointing those out!

 lib/engine/gui/gtk-frontend/call-window.cpp |    1 -
 lib/engine/gui/gtk-frontend/chat-area.cpp   |    1 -
 lib/engine/videoinput/videoinput-core.cpp   |    7 ++++---
 lib/gui/gmvideowidget.c                     |    2 +-
 lib/platform/platform.c                     |    2 ++
 5 files changed, 7 insertions(+), 6 deletions(-)
---
diff --git a/lib/engine/gui/gtk-frontend/call-window.cpp b/lib/engine/gui/gtk-frontend/call-window.cpp
index 649ca26..c46cecc 100644
--- a/lib/engine/gui/gtk-frontend/call-window.cpp
+++ b/lib/engine/gui/gtk-frontend/call-window.cpp
@@ -2094,7 +2094,6 @@ ekiga_call_window_init_gui (EkigaCallWindow *cw)
   vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 0);
   frame = gtk_frame_new (NULL);
   gtk_frame_set_shadow_type (GTK_FRAME (frame), GTK_SHADOW_NONE);
-  event_box = gtk_event_box_new ();
   gtk_container_set_border_width (GTK_CONTAINER (frame), 0);
   gtk_container_add (GTK_CONTAINER (event_box), vbox);
   gtk_container_add (GTK_CONTAINER (frame), event_box);
diff --git a/lib/engine/gui/gtk-frontend/chat-area.cpp b/lib/engine/gui/gtk-frontend/chat-area.cpp
index 8d7ec8f..e11ded9 100644
--- a/lib/engine/gui/gtk-frontend/chat-area.cpp
+++ b/lib/engine/gui/gtk-frontend/chat-area.cpp
@@ -688,7 +688,6 @@ chat_area_init (ChatArea* self)
   self->priv->text_view = gtk_text_view_new ();
   g_signal_connect (self->priv->text_view, "motion-notify-event",
                    G_CALLBACK (on_motion_notify_event), NULL);
-  buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (self->priv->text_view));
 
   gtk_text_view_set_editable (GTK_TEXT_VIEW (self->priv->text_view), FALSE);
   gtk_text_view_set_cursor_visible (GTK_TEXT_VIEW (self->priv->text_view),
diff --git a/lib/engine/videoinput/videoinput-core.cpp b/lib/engine/videoinput/videoinput-core.cpp
index c06f2fc..ed75e9f 100644
--- a/lib/engine/videoinput/videoinput-core.cpp
+++ b/lib/engine/videoinput/videoinput-core.cpp
@@ -115,7 +115,7 @@ void VideoInputCore::VideoPreviewManager::Main ()
 {
   PWaitAndSignal m(thread_mutex);
   bool exit = end_thread;
-  bool capture = !pause_thread;
+  bool capture;
 
   while (!exit) {
 
@@ -391,12 +391,13 @@ void VideoInputCore::set_preview_config (unsigned width, unsigned height, unsign
 {
   PWaitAndSignal m(core_mutex);
 
-  VideoDeviceConfig new_preview_config(width, height, fps);
-
   if ( fps < 1 || fps > 30 ) {
     PTRACE(1, "VidInputCore\tmax-frame-rate out of range, ajusting to 30");
     fps = 30;
   }
+
+  VideoDeviceConfig new_preview_config(width, height, fps);
+
   PTRACE(4, "VidInputCore\tSetting new preview config: " << new_preview_config);
   // There is only one state where we have to reopen the preview device:
   // we have preview enabled, no stream is active and some value has changed
diff --git a/lib/gui/gmvideowidget.c b/lib/gui/gmvideowidget.c
index 7e36fcc..455575f 100644
--- a/lib/gui/gmvideowidget.c
+++ b/lib/gui/gmvideowidget.c
@@ -774,7 +774,7 @@ void
 gm_video_widget_set_fullscreen (GmVideoWidget *self,
                                 const gboolean fs)
 {
-  g_return_val_if_fail (GM_IS_VIDEO_WIDGET (self), -1);
+  g_return_if_fail (GM_IS_VIDEO_WIDGET (self));
 
   ClutterActor *stage = NULL;
 
diff --git a/lib/platform/platform.c b/lib/platform/platform.c
index 55e3361..a291c61 100644
--- a/lib/platform/platform.c
+++ b/lib/platform/platform.c
@@ -122,6 +122,8 @@ gm_platform_open_uri_fallback (const gchar *uri)
     success = g_spawn_command_line_async (commandline, NULL);
     g_free (commandline);
   }
+
+  g_return_if_fail (success);
 }
 
 void