[gnome-shell] LookingGlass: Correct timeout usage



commit 68b2d5fcf05b08bffccae386a76c2088a65a0377
Author: Bastien Nocera <hadess hadess net>
Date:   Thu Apr 10 21:08:49 2014 +0200

    LookingGlass: Correct timeout usage
    
    Calling Mainloop.source_remove() on the timeout ID will not reset it,
    and we're already removing the timeout by returning GLib.SOURCE_REMOVE
    in the callback.

 js/ui/lookingGlass.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js
index 2dccc99..a39d713 100644
--- a/js/ui/lookingGlass.js
+++ b/js/ui/lookingGlass.js
@@ -843,7 +843,7 @@ const LookingGlass = new Lang.Class({
            System.gc();
            this._timeoutId = Mainloop.timeout_add(500, Lang.bind(this, function () {
                 gcIcon.icon_name = 'gnome-fs-trash-full';
-                Mainloop.source_remove(this._timeoutId);
+                this._timeoutId = 0;
                 return GLib.SOURCE_REMOVE;
            }));
            GLib.Source.set_name_by_id(this._timeoutId, '[gnome-shell] gcIcon.icon_name = 
\'gnome-fs-trash-full\'');


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]