[dia] [warningectomy] unused variable (shadowed)



commit 832d3b4286d7e984eb98a98aecf4a7d506d52abc
Author: Hans Breuer <hans breuer org>
Date:   Sat Apr 5 20:38:16 2014 +0200

    [warningectomy] unused variable (shadowed)
    
    dia_xml.c:273:17: warning: unused variable 'ret' [-Wunused-variable]
          xmlDocPtr ret = xmlDoParseFile(fname, &error_xml);
                    ^
    dia_xml.c:300:15: warning: unused variable 'err' [-Wunused-variable]
      xmlErrorPtr err;
                  ^
    The first one was actually a bu which would have failed with files
    missing encoding and not utf-8.

 lib/dia_xml.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/lib/dia_xml.c b/lib/dia_xml.c
index 13220cd..a63e4ac 100644
--- a/lib/dia_xml.c
+++ b/lib/dia_xml.c
@@ -270,7 +270,7 @@ xmlDiaParseFile(const char *filename, DiaContext *ctx)
     const gchar *fname = xml_file_check_encoding(filename,local_charset, ctx);
     if (fname != filename) {
       /* We've got a corrected file to parse. */
-      xmlDocPtr ret = xmlDoParseFile(fname, &error_xml);
+      ret = xmlDoParseFile(fname, &error_xml);
       unlink(fname);
       /* printf("has read %s instead of %s\n",fname,filename); */
       g_free((void *)fname);
@@ -297,7 +297,6 @@ xmlDocPtr
 xmlDoParseFile(const char *filename, xmlErrorPtr *error)
 {
   xmlDocPtr doc;
-  xmlErrorPtr err;
 
   doc = xmlParseFile(filename);
   if (!doc && error)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]