[vte] a11y: Don't explicitly set accessible parent



commit 31810bc64a72903b5dfd21bec950b0afb183e679
Author: Christian Persch <chpe gnome org>
Date:   Sun Apr 6 11:12:07 2014 +0200

    a11y: Don't explicitly set accessible parent
    
    Most other widget's a11y implementations don't do this either.

 src/vteaccess.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
---
diff --git a/src/vteaccess.c b/src/vteaccess.c
index 12eb306..9f77530 100644
--- a/src/vteaccess.c
+++ b/src/vteaccess.c
@@ -720,19 +720,11 @@ vte_terminal_accessible_initialize (AtkObject *obj, gpointer data)
                         G_CALLBACK(vte_terminal_accessible_title_changed),
                         obj);
 
-       /* everything below copied from gtkwidgetaccessible.c */
        g_signal_connect(terminal, "visibility-notify-event",
                G_CALLBACK(vte_terminal_accessible_visibility_notify), obj);
        g_signal_connect(terminal, "selection-changed",
                G_CALLBACK(vte_terminal_accessible_selection_changed), obj);
 
-       if (GTK_IS_WIDGET(gtk_widget_get_parent(GTK_WIDGET(terminal)))) {
-               parent = gtk_widget_get_accessible(gtk_widget_get_parent ((GTK_WIDGET(terminal))));
-               if (ATK_IS_OBJECT(parent)) {
-                       atk_object_set_parent(obj, parent);
-               }
-       }
-
        atk_object_set_name(obj, "Terminal");
         window_title = vte_terminal_get_window_title(terminal);
        atk_object_set_description(obj, window_title ? window_title : "");
@@ -743,7 +735,7 @@ vte_terminal_accessible_initialize (AtkObject *obj, gpointer data)
                                       ATK_STATE_EXPANDABLE, FALSE);
        atk_object_notify_state_change(obj,
                                       ATK_STATE_RESIZABLE, TRUE);
-       obj->role = ATK_ROLE_TERMINAL;
+        atk_object_set_role(obj, ATK_ROLE_TERMINAL);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]