[gtk+/gtk-3-10] GtkLabel: don't eat too many button release events
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-10] GtkLabel: don't eat too many button release events
- Date: Sun, 6 Apr 2014 03:41:42 +0000 (UTC)
commit 6e433c08e8706651497af172e7dcf54be926968b
Author: Matthias Clasen <mclasen redhat com>
Date: Mon Feb 17 23:09:44 2014 -0500
GtkLabel: don't eat too many button release events
We should only eat button release events when the label is
actually selectable, since the comment indicates that we
want to eat the release events belonging to press events
that triggered a selection. This fixes problems with actions
on parent widgets that are triggered by button release,
as seen in this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=724541
gtk/gtklabel.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 2333f63..8cdb83b 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -4829,7 +4829,10 @@ gtk_label_button_release (GtkWidget *widget,
/* The goal here is to return TRUE iff we ate the
* button press to start selecting.
*/
- return TRUE;
+ if (info->selectable)
+ return TRUE;
+
+ return FALSE;
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]