[network-manager-applet] applet: don't show PIN unlock dialog before keyring search is done



commit 9b669a7c9e19d7da8cb6ea0720ab96392caaee3f
Author: Dan Williams <dcbw redhat com>
Date:   Thu Apr 3 15:25:54 2014 -0500

    applet: don't show PIN unlock dialog before keyring search is done
    
    Possible mis-merge of 8f49c2c7.  If the modem doesn't have a device
    identifier or required unlock isn't a PIN, the second call to
    unlock_dialog_new() would have no effect because unlock_dialog_new()
    just returns if a dialog is already showing.  But if the PIN could
    be in the keyring, the search would be started and the dialog would
    be shown anyway, which is wrong.

 src/applet-device-broadband.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/src/applet-device-broadband.c b/src/applet-device-broadband.c
index 52ac959..6790993 100644
--- a/src/applet-device-broadband.c
+++ b/src/applet-device-broadband.c
@@ -449,9 +449,6 @@ modem_get_sim_ready (MMModem *modem,
                /* Couldn't get a device ID, but unlock required; present dialog */
                unlock_dialog_new (info->device, info);
        }
-
-       /* Couldn't get a device ID, but unlock required; present dialog */
-       unlock_dialog_new (info->device, info);
 }
 
 /********************************************************************/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]