[glibmm] Add a TODO comment



commit 415335bfd0a2393dd2650b483dbae4bb605c56e2
Author: Murray Cumming <murrayc murrayc com>
Date:   Thu Apr 3 11:00:07 2014 +0200

    Add a TODO comment

 gio/src/actiongroup.hg |    2 ++
 glib/src/variant.ccg   |    2 +-
 glib/src/variant.hg    |    1 +
 3 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/gio/src/actiongroup.hg b/gio/src/actiongroup.hg
index 434b7fa..54411cf 100644
--- a/gio/src/actiongroup.hg
+++ b/gio/src/actiongroup.hg
@@ -173,6 +173,8 @@ void ActionGroup::get_action_state(const Glib::ustring& action_name, T_Value& va
     g_variant_type_equal(g_action_group_get_action_state_type(const_cast<GActionGroup*>(gobj()), 
action_name.c_str()), type_glib_variant::variant_type().gobj()));
 
   const Glib::VariantBase variantBase = get_action_state_variant(action_name);
+
+  //TODO: Add a bool return instead of letting a std::bad_cast from the cast_dynamic() be thrown up to the 
caller?
   const type_glib_variant variantDerived = variantBase.cast_dynamic<type_glib_variant>(variantBase);
   value = variantDerived.get();
 }
diff --git a/glib/src/variant.ccg b/glib/src/variant.ccg
index bfdff9f..1689e6b 100644
--- a/glib/src/variant.ccg
+++ b/glib/src/variant.ccg
@@ -58,7 +58,7 @@ void VariantBase::get_normal_form(VariantBase& result) const
   GVariant* const g_value =
     g_variant_get_normal_form(const_cast<GVariant*>(gobj()));
 
-  //The C function never returns NULL, according to its docuemenation,
+  //The C function never returns NULL, according to its documenation,
   //so we don't need a bool return value.
   result.init(g_value); // g_value is already referenced.
 }
diff --git a/glib/src/variant.hg b/glib/src/variant.hg
index 9c9e686..0cb1a82 100644
--- a/glib/src/variant.hg
+++ b/glib/src/variant.hg
@@ -456,6 +456,7 @@ public:
   //TODO: Documentation
   void get(VariantBase& variant) const;
 
+  //TODO: Deprecate this in favour of get(VariantBase&)?
   _WRAP_METHOD(VariantBase get() const, g_variant_get_variant)
 };
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]