[gtk+/popover-menu-buttons: 4/5] popover: Use display-hint for menus

[Matthias Clasen <matthiasc src gnome org>]

commit f628dac725b12c9e0d5a6f80787a475d2fd89da9
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Apr 2 01:07:32 2014 -0400

    popover: Use display-hint for menus
    
    When an 'iconic' display-hint is specified on a section,
    render the actions as a row of icon buttons, instead of
    menuitems.

 gtk/gtkpopover.c |   72 +++++++++++++++++++++++++++++++++++++++++++++---------
 1 files changed, 60 insertions(+), 12 deletions(-)
---
diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c
index d9ce632..82c3880 100644
--- a/gtk/gtkpopover.c
+++ b/gtk/gtkpopover.c
@@ -59,6 +59,7 @@
 #include "gtkwidgetprivate.h"
 #include "gtkactionmuxer.h"
 #include "gtkmenutracker.h"
+#include "gtkmenutrackeritem.h"
 #include "gtkstack.h"
 #include "gtksizegroup.h"
 #include "a11y/gtkpopoveraccessible.h"
@@ -2004,10 +2005,10 @@ gtk_popover_tracker_insert_func (GtkMenuTrackerItem *item,
       GtkWidget *separator;
       const gchar *label;
 
-      separator = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
- 
       label = gtk_menu_tracker_item_get_label (item);
 
+      separator = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
+
       if (label != NULL)
         {
           GtkWidget *title;
@@ -2092,18 +2093,65 @@ gtk_popover_tracker_insert_func (GtkMenuTrackerItem *item,
     }
   else
     {
-      widget = gtk_model_button_new ();
-      g_object_bind_property (item, "label", widget, "text", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "icon", widget, "icon", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "sensitive", widget, "sensitive", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "visible", widget, "visible", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "role", widget, "action-role", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "toggled", widget, "toggled", G_BINDING_SYNC_CREATE);
-      g_object_bind_property (item, "accel", widget, "accel", G_BINDING_SYNC_CREATE);
+      const gchar *hint;
+      GtkWidget *icon_box = NULL;
 
-      g_signal_connect (widget, "clicked", G_CALLBACK (gtk_popover_item_activate), item);
-    }
+      hint = gtk_menu_tracker_item_get_display_hint (item);
+      if (g_strcmp0 (hint, "iconic") == 0)
+        {
+          GList *l;
+          GtkWidget *sibling = NULL;
+          l = gtk_container_get_children (GTK_CONTAINER (box));
+          sibling = g_list_nth_data (l, position);
+          g_list_free (l);
+          if (sibling)
+            icon_box = GTK_WIDGET (g_object_get_data (G_OBJECT (sibling), "iconic-section"));
+          if (GTK_IS_BOX (icon_box))
+            {
+              widget = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
+              gtk_widget_set_no_show_all (widget, TRUE);
+              g_object_set_data (G_OBJECT (widget), "iconic-section", icon_box);
+            }
+          else
+            {
+              icon_box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
+              gtk_widget_set_halign (icon_box, GTK_ALIGN_FILL);
+              gtk_style_context_add_class (gtk_widget_get_style_context (icon_box), GTK_STYLE_CLASS_LINKED);
+              gtk_widget_show (icon_box);
+              g_object_set_data (G_OBJECT (icon_box), "iconic-section", icon_box);
+              widget = icon_box;
+            }
+        }
 
+      if (icon_box)
+        {
+          GtkWidget *button;
+        
+          if (gtk_menu_tracker_item_get_role (item) != GTK_MENU_TRACKER_ITEM_ROLE_NORMAL)
+            g_warning ("Only normal actions supported in icon section");
+
+          button = gtk_button_new_from_icon_name ("process-stop-symbolic", GTK_ICON_SIZE_MENU);
+          g_object_bind_property (item, "icon", gtk_button_get_image (GTK_BUTTON (button)), "gicon", 
G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "sensitive", button, "sensitive", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "visible", button, "visible", G_BINDING_SYNC_CREATE);
+          g_signal_connect (button, "clicked", G_CALLBACK (gtk_popover_item_activate), item);
+          g_object_set_data_full (G_OBJECT (button), "GtkMenuTrackerItem", g_object_ref (item), 
g_object_unref);
+          gtk_box_pack_end (GTK_BOX (icon_box), button, TRUE, TRUE, 0);
+        }
+      else
+        {
+          widget = gtk_model_button_new ();
+          g_object_bind_property (item, "label", widget, "text", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "icon", widget, "icon", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "sensitive", widget, "sensitive", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "visible", widget, "visible", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "role", widget, "action-role", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "toggled", widget, "toggled", G_BINDING_SYNC_CREATE);
+          g_object_bind_property (item, "accel", widget, "accel", G_BINDING_SYNC_CREATE);
+
+          g_signal_connect (widget, "clicked", G_CALLBACK (gtk_popover_item_activate), item);
+        }
+    }
   g_object_set_data_full (G_OBJECT (widget), "GtkMenuTrackerItem", g_object_ref (item), g_object_unref);
 
   gtk_container_add (GTK_CONTAINER (box), widget);