[bijiben/gnome-3-10] Book: always signal mass-change when a provider a loaded
- From: Pierre-Yves Luyten <pyluyten src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [bijiben/gnome-3-10] Book: always signal mass-change when a provider a loaded
- Date: Thu, 26 Sep 2013 21:05:50 +0000 (UTC)
commit ebf20c0043a57144fcee1a0bf486e2d96db01228
Author: Pierre-Yves Luyten <py luyten fr>
Date: Thu Sep 26 23:04:10 2013 +0200
Book: always signal mass-change when a provider a loaded
This might be the first provider. See 708458
src/libbiji/biji-note-book.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
---
diff --git a/src/libbiji/biji-note-book.c b/src/libbiji/biji-note-book.c
index dd3c89f..2cb416b 100644
--- a/src/libbiji/biji-note-book.c
+++ b/src/libbiji/biji-note-book.c
@@ -262,6 +262,7 @@ biji_note_book_notify_changed (BijiNoteBook *book,
BijiNoteBookChangeFlag flag,
BijiItem *item)
{
+ g_debug ("book: notify changed, %i", flag);
g_signal_emit (book,
biji_book_signals[BOOK_AMENDED],
0,
@@ -337,15 +338,15 @@ on_provider_loaded_cb (BijiProvider *provider,
}
}
- if (i==1)
- flag = BIJI_BOOK_ITEM_ADDED;
- else if (i>1)
- flag = BIJI_BOOK_MASS_CHANGE;
+ g_debug ("on provider loaded: %i", i);
- if (flag > BIJI_BOOK_CHANGE_FLAG)
- biji_note_book_notify_changed (book, flag, item);
+ /* More cautious to ask to fully rebuild the model
+ * because this might be the first provider.
+ * See #708458
+ * There are more performant fixes but not worth it */
+ biji_note_book_notify_changed (book, BIJI_BOOK_MASS_CHANGE, item);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]