[gnome-shell/wip/app-system-rewrite: 1/13] search: Actually crash when seeing errors from a native search provider



commit 5340e2b00789a8116439de96d6eb03fd968d815d
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Thu Jul 25 23:08:27 2013 -0400

    search: Actually crash when seeing errors from a native search provider
    
    We don't implement many of these, and not catching the error lets us
    see stack traces and other such information a lot faster.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704912

 js/ui/search.js |   16 ++++------------
 1 files changed, 4 insertions(+), 12 deletions(-)
---
diff --git a/js/ui/search.js b/js/ui/search.js
index 1fd442e..3648fa1 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -82,22 +82,14 @@ const SearchSystem = new Lang.Class({
         if (isSubSearch) {
             for (let i = 0; i < this._providers.length; i++) {
                 let [provider, previousResults] = previousResultsArr[i];
-                try {
-                    results.push([provider, []]);
-                    provider.getSubsearchResultSet(previousResults, terms);
-                } catch (error) {
-                    log('A ' + error.name + ' has occured in ' + provider.id + ': ' + error.message);
-                }
+                results.push([provider, []]);
+                provider.getSubsearchResultSet(previousResults, terms);
             }
         } else {
             for (let i = 0; i < this._providers.length; i++) {
                 let provider = this._providers[i];
-                try {
-                    results.push([provider, []]);
-                    provider.getInitialResultSet(terms);
-                } catch (error) {
-                    log('A ' + error.name + ' has occured in ' + provider.id + ': ' + error.message);
-                }
+                results.push([provider, []]);
+                provider.getInitialResultSet(terms);
             }
         }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]