[gnome-software] trivial: Reduce the amount of debugging shown at startup

[Richard Hughes <rhughes src gnome org>]

commit 019149a7febd4f7d251caade141d3c51b659ae09
Author: Richard Hughes <richard hughsie com>
Date:   Thu Sep 26 13:05:45 2013 +0100

    trivial: Reduce the amount of debugging shown at startup

 src/gs-app.c                               |    2 --
 src/gs-plugin-loader.c                     |    1 -
 src/gs-shell-installed.c                   |    1 -
 src/gs-shell-search.c                      |    1 -
 src/plugins/gs-plugin-appstream.c          |   23 ++++++-----------------
 src/plugins/gs-plugin-datadir-apps.c       |    2 --
 src/plugins/gs-plugin-packagekit-history.c |    2 --
 7 files changed, 6 insertions(+), 26 deletions(-)
---
diff --git a/src/gs-app.c b/src/gs-app.c
index e004658..f8c915f 100644
--- a/src/gs-app.c
+++ b/src/gs-app.c
@@ -749,8 +749,6 @@ void
 gs_app_set_metadata (GsApp *app, const gchar *key, const gchar *value)
 {
        g_return_if_fail (GS_IS_APP (app));
-       g_debug ("setting %s to %s for %s",
-                key, value, gs_app_get_id (app));
        g_hash_table_insert (app->priv->metadata,
                             g_strdup (key),
                             g_strdup (value));
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index 694dbab..c7acbc2 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -102,7 +102,6 @@ gs_plugin_loader_dedupe (GsPluginLoader *plugin_loader, GsApp *app)
                 * but it allows us to do:
                 * app = gs_plugin_loader_dedupe (cache, app);
                 */
-               g_debug ("deduped %s", gs_app_get_id (app));
                g_object_unref (app);
                g_object_ref (new_app);
                goto out;
diff --git a/src/gs-shell-installed.c b/src/gs-shell-installed.c
index 5ccda24..d64ce17 100644
--- a/src/gs-shell-installed.c
+++ b/src/gs-shell-installed.c
@@ -198,7 +198,6 @@ gs_shell_installed_add_app (GsShellInstalled *shell, GsApp *app)
        GsShellInstalledPrivate *priv = shell->priv;
        GtkWidget *widget;
 
-       g_debug ("adding to installed list: %s", gs_app_get_id (app));
        widget = gs_app_widget_new ();
        gs_app_widget_set_colorful (GS_APP_WIDGET (widget), FALSE);
        g_signal_connect (widget, "button-clicked",
diff --git a/src/gs-shell-search.c b/src/gs-shell-search.c
index 4b25639..06b2069 100644
--- a/src/gs-shell-search.c
+++ b/src/gs-shell-search.c
@@ -188,7 +188,6 @@ gs_shell_search_get_search_cb (GObject *source_object,
        gtk_stack_set_visible_child_name (GTK_STACK (widget), "results");
        for (l = list; l != NULL; l = l->next) {
                app = GS_APP (l->data);
-               g_debug ("adding search %s", gs_app_get_id (app));
                widget = gs_app_widget_new ();
                g_signal_connect (widget, "button-clicked",
                                  G_CALLBACK (gs_shell_search_app_widget_clicked_cb),
diff --git a/src/plugins/gs-plugin-appstream.c b/src/plugins/gs-plugin-appstream.c
index 0ce07f6..43d76bb 100644
--- a/src/plugins/gs-plugin-appstream.c
+++ b/src/plugins/gs-plugin-appstream.c
@@ -180,30 +180,23 @@ gs_plugin_destroy (GsPlugin *plugin)
 static gboolean
 gs_plugin_startup (GsPlugin *plugin, GError **error)
 {
-       gboolean ret = TRUE;
-       GTimer *timer = NULL;
+       gboolean ret;
        guint size;
 
        /* Parse the XML */
-       timer = g_timer_new ();
        ret = gs_plugin_parse_xml (plugin, error);
        if (!ret)
                goto out;
        size = appstream_cache_get_size (plugin->priv->cache);
        if (size == 0) {
                g_warning ("No AppStream data, try 'make install-sample-data' in data/");
-                g_set_error (error,
-                             gs_plugin_loader_error_quark (),
-                             GS_PLUGIN_LOADER_ERROR_FAILED,
-                             _("No AppStream data found"));
-               //g_assert_not_reached ();
+               g_set_error (error,
+                            GS_PLUGIN_LOADER_ERROR,
+                            GS_PLUGIN_LOADER_ERROR_FAILED,
+                            _("No AppStream data found"));
                goto out;
        }
-       g_debug ("Parsed %i entries of XML\t:%.1fms", size,
-                g_timer_elapsed (timer, NULL) * 1000);
 out:
-       if (timer != NULL)
-               g_timer_destroy (timer);
        return ret;
 }
 
@@ -316,8 +309,6 @@ gs_plugin_refine_item (GsPlugin *plugin,
 {
        gboolean ret = TRUE;
 
-       g_debug ("AppStream: Refining %s", gs_app_get_id (app));
-
        /* is an app */
        if (gs_app_get_kind (app) == GS_APP_KIND_UNKNOWN ||
            gs_app_get_kind (app) == GS_APP_KIND_PACKAGE)
@@ -371,10 +362,8 @@ gs_plugin_refine_from_id (GsPlugin *plugin,
        if (id == NULL)
                goto out;
        item = appstream_cache_get_item_by_id (plugin->priv->cache, id);
-       if (item == NULL) {
-               g_debug ("no AppStream match for [id] %s", id);
+       if (item == NULL)
                goto out;
-       }
 
        /* set new properties */
        ret = gs_plugin_refine_item (plugin, app, item, error);
diff --git a/src/plugins/gs-plugin-datadir-apps.c b/src/plugins/gs-plugin-datadir-apps.c
index 80443d3..40cd8b9 100644
--- a/src/plugins/gs-plugin-datadir-apps.c
+++ b/src/plugins/gs-plugin-datadir-apps.c
@@ -212,8 +212,6 @@ gs_plugin_datadir_apps_extract_desktop_data (GsPlugin *plugin,
        basename_tmp = basename;
        if (g_str_has_prefix (basename_tmp, "fedora-"))
                basename_tmp += 7;
-       g_debug ("setting new id for %s to %s",
-                gs_app_get_id (app), basename_tmp);
        cache_item->id = g_strdup (basename_tmp);
 
        /* add to cache */
diff --git a/src/plugins/gs-plugin-packagekit-history.c b/src/plugins/gs-plugin-packagekit-history.c
index 6060d64..c43c9db 100644
--- a/src/plugins/gs-plugin-packagekit-history.c
+++ b/src/plugins/gs-plugin-packagekit-history.c
@@ -217,8 +217,6 @@ gs_plugin_packagekit_refine (GsPlugin *plugin,
                                gs_app_add_history (app, app_dummy);
                                g_object_unref (app_dummy);
                        }
-                       g_debug ("no history for %s, setting timestamp nonzero",
-                                gs_app_get_source (app));
                        gs_app_set_install_date (app, GS_APP_INSTALL_DATE_UNKNOWN);
                        continue;
                }