[gnome-shell] authPrompt: Clear _queryingService on verification failure
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] authPrompt: Clear _queryingService on verification failure
- Date: Mon, 23 Sep 2013 11:33:58 +0000 (UTC)
commit 02c99e4b25d0a2b19a304d2a5e893f867274c54f
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Sep 18 20:23:53 2013 +0200
authPrompt: Clear _queryingService on verification failure
A conversation is finished after failing, and we are expecting a new
one to be started shortly after. However if we encounter an existing
reference to a previously set _queryingService, we will clear the
password entry, which might already contain a partially typed password
at that point. The behavior does make sense in the case of conflicting
conversations, but in the failure case it is both unexpected and
annoying, so clear _queryingService early to prevent this.
https://bugzilla.gnome.org/show_bug.cgi?id=708186
js/gdm/authPrompt.js | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js
index 90fefcf..fe2cf2d 100644
--- a/js/gdm/authPrompt.js
+++ b/js/gdm/authPrompt.js
@@ -244,6 +244,7 @@ const AuthPrompt = new Lang.Class({
},
_onVerificationFailed: function() {
+ this._queryingService = null;
this.clear();
this.updateSensitivity(true);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]