[gnome-bluetooth] lib: Fix double-free when finishing connection



commit 3d77ac7f8f928b00ec5cb0af7e29aa2bf2dbfde7
Author: Bastien Nocera <hadess hadess net>
Date:   Fri Sep 20 19:45:25 2013 +0200

    lib: Fix double-free when finishing connection
    
    The proxy was already unref'ed when we started the
    connection/disconnection so the only places that should hold a reference
    are the tree model, and the operation itself.
    
    Fixes the bugs reported in:
    http://retrace.fedoraproject.org/faf/reports/205937/
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708477

 lib/bluetooth-client.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/lib/bluetooth-client.c b/lib/bluetooth-client.c
index ffa3907..0cc7b6d 100644
--- a/lib/bluetooth-client.c
+++ b/lib/bluetooth-client.c
@@ -1462,7 +1462,6 @@ connect_callback (GDBusProxy   *proxy,
        g_simple_async_result_complete_in_idle (simple);
 
        g_object_unref (simple);
-       g_object_unref (proxy);
 }
 
 static void
@@ -1487,7 +1486,6 @@ disconnect_callback (GDBusProxy   *proxy,
 
        g_simple_async_result_complete_in_idle (simple);
 
-       g_object_unref (proxy);
        g_object_unref (simple);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]