[gtksourceview] SearchSettings: change default value of wrap-around to FALSE
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtksourceview] SearchSettings: change default value of wrap-around to FALSE
- Date: Fri, 13 Sep 2013 13:02:36 +0000 (UTC)
commit 27f68ad818cb4baa9680e73fdeec3ccf6248e30d
Author: Sébastien Wilmet <swilmet gnome org>
Date: Fri Sep 13 14:48:56 2013 +0200
SearchSettings: change default value of wrap-around to FALSE
When using the search API for another purpose than the normal search and
replace feature (tests, background searches, ...), if the wrap-around is
TRUE, this can lead to infinite loops, and it takes some time to
understand why (especially for performances tests, but it was actually a
good thing to have the wrap-around to TRUE in this case).
gtksourceview/gtksourcesearchsettings.c | 2 +-
tests/test-search-context.c | 2 --
tests/test-search-performances.c | 1 -
tests/test-search.ui | 1 -
4 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/gtksourceview/gtksourcesearchsettings.c b/gtksourceview/gtksourcesearchsettings.c
index e3556bd..5f5269b 100644
--- a/gtksourceview/gtksourcesearchsettings.c
+++ b/gtksourceview/gtksourcesearchsettings.c
@@ -216,7 +216,7 @@ gtk_source_search_settings_class_init (GtkSourceSearchSettingsClass *klass)
g_param_spec_boolean ("wrap-around",
_("Wrap around"),
_("Wrap around"),
- TRUE,
+ FALSE,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT));
/**
diff --git a/tests/test-search-context.c b/tests/test-search-context.c
index de86b4f..e8d9160 100644
--- a/tests/test-search-context.c
+++ b/tests/test-search-context.c
@@ -583,7 +583,6 @@ test_async_forward_search_normal (void)
gtk_text_buffer_set_text (text_buffer, "aaaa", -1);
gtk_source_search_settings_set_search_text (settings, "aa");
- gtk_source_search_settings_set_wrap_around (settings, FALSE);
check_async_search_results (context, results, TRUE, TRUE);
@@ -705,7 +704,6 @@ test_async_backward_search_normal (void)
gtk_text_buffer_set_text (text_buffer, "aaaa", -1);
gtk_source_search_settings_set_search_text (settings, "aa");
- gtk_source_search_settings_set_wrap_around (settings, FALSE);
check_async_search_results (context, results, FALSE, TRUE);
diff --git a/tests/test-search-performances.c b/tests/test-search-performances.c
index d2bf98b..1b7c622 100644
--- a/tests/test-search-performances.c
+++ b/tests/test-search-performances.c
@@ -136,7 +136,6 @@ main (int argc, char *argv[])
g_timer_start (timer);
- gtk_source_search_settings_set_wrap_around (search_settings, FALSE);
gtk_source_search_settings_set_search_text (search_settings, "foo");
gtk_text_buffer_get_start_iter (GTK_TEXT_BUFFER (buffer), &iter);
diff --git a/tests/test-search.ui b/tests/test-search.ui
index c4d3e3b..3762e5f 100644
--- a/tests/test-search.ui
+++ b/tests/test-search.ui
@@ -219,7 +219,6 @@
<property name="can_focus">True</property>
<property name="receives_default">False</property>
<property name="xalign">0</property>
- <property name="active">True</property>
<property name="draw_indicator">True</property>
<signal name="toggled" handler="wrap_around_toggled_cb" object="TestSearch" swapped="yes"/>
</object>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]