[gnome-online-accounts] goabackend: Use Unicode quotation marks instead of backticks
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts] goabackend: Use Unicode quotation marks instead of backticks
- Date: Fri, 6 Sep 2013 09:34:37 +0000 (UTC)
commit b9538cadfbe36becc9d632d3a359cb000d3913b4
Author: Philip Withnall <philip tecnocode co uk>
Date: Tue Sep 3 22:09:25 2013 -0600
goabackend: Use Unicode quotation marks instead of backticks
Backticks should be banished to the 20th century. This also merges
a couple of strings which differed only in the name of a data
structure key (which shouldn’t be translated).
Fixes: https://bugzilla.gnome.org/707435
src/goabackend/goaexchangeprovider.c | 6 +++---
src/goabackend/goaimapsmtpprovider.c | 26 +++++++++++++++++++-------
src/goabackend/goakerberosprovider.c | 4 ++--
src/goabackend/goaoauth2provider.c | 4 ++--
src/goabackend/goaowncloudprovider.c | 6 +++---
src/goabackend/goautils.c | 4 ++--
6 files changed, 31 insertions(+), 19 deletions(-)
---
diff --git a/src/goabackend/goaexchangeprovider.c b/src/goabackend/goaexchangeprovider.c
index 51f446d..c45e705 100644
--- a/src/goabackend/goaexchangeprovider.c
+++ b/src/goabackend/goaexchangeprovider.c
@@ -314,7 +314,7 @@ ensure_credentials_sync (GoaProvider *provider,
{
*error = g_error_new (GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Did not find password with identity `%s' in credentials"),
+ _("Did not find password with identity ‘%s’ in credentials"),
username);
}
goto out;
@@ -342,7 +342,7 @@ ensure_credentials_sync (GoaProvider *provider,
* (eg., debarshi ray gmail com or rishi), and the
* (%s, %d) is the error domain and code.
*/
- _("Invalid password with username `%s' (%s, %d): "),
+ _("Invalid password with username ‘%s’ (%s, %d): "),
username,
g_quark_to_string ((*error)->domain),
(*error)->code);
@@ -1025,7 +1025,7 @@ on_handle_get_password (GoaPasswordBased *interface,
g_dbus_method_invocation_return_error (invocation,
GOA_ERROR,
GOA_ERROR_FAILED, /* TODO: more specific */
- _("Did not find password with identity `%s' in credentials"),
+ _("Did not find password with identity ‘%s’ in credentials"),
identity);
goto out;
}
diff --git a/src/goabackend/goaimapsmtpprovider.c b/src/goabackend/goaimapsmtpprovider.c
index 6c83a87..bcc51b6 100644
--- a/src/goabackend/goaimapsmtpprovider.c
+++ b/src/goabackend/goaimapsmtpprovider.c
@@ -359,7 +359,10 @@ ensure_credentials_sync (GoaProvider *provider,
{
*error = g_error_new (GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Did not find imap-password with identity `%s' in credentials"),
+ /* Translators: the first parameter is a field name. The second is
+ * a GOA account identifier. */
+ _("Did not find %s with identity ‘%s’ in credentials"),
+ "imap-password",
identity);
}
goto out;
@@ -384,11 +387,13 @@ ensure_credentials_sync (GoaProvider *provider,
if (error != NULL)
{
g_prefix_error (error,
- /* Translators: the first %s is the IMAP
+ /* Translators: the first %s is a field name. The
+ * second %s is the IMAP
* username (eg., rishi), and the (%s, %d)
* is the error domain and code.
*/
- _("Invalid imap-password with username `%s' (%s, %d): "),
+ _("Invalid %s with username ‘%s’ (%s, %d): "),
+ "imap-password",
imap_username,
g_quark_to_string ((*error)->domain),
(*error)->code);
@@ -412,7 +417,10 @@ ensure_credentials_sync (GoaProvider *provider,
{
*error = g_error_new (GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Did not find smtp-password with identity `%s' in credentials"),
+ /* Translators: the first parameter is a field name. The second is
+ * a GOA account identifier. */
+ _("Did not find %s with identity ‘%s’ in credentials"),
+ "smtp-password",
identity);
}
goto out;
@@ -439,11 +447,13 @@ ensure_credentials_sync (GoaProvider *provider,
if (error != NULL)
{
g_prefix_error (error,
- /* Translators: the first %s is the SMTP
+ /* Translators: the first %s is a field name. The
+ * second %s is the SMTP
* username (eg., rishi), and the (%s, %d)
* is the error domain and code.
*/
- _("Invalid smtp-password with username `%s' (%s, %d): "),
+ _("Invalid %s with username ‘%s’ (%s, %d): "),
+ "smtp-password",
imap_username,
g_quark_to_string ((*error)->domain),
(*error)->code);
@@ -1617,7 +1627,9 @@ on_handle_get_password (GoaPasswordBased *interface,
g_dbus_method_invocation_return_error (invocation,
GOA_ERROR,
GOA_ERROR_FAILED, /* TODO: more specific */
- "Did not find %s with identity `%s' in credentials",
+ /* Translators: the first parameter is a field name.
+ * The second is a GOA account identifier. */
+ "Did not find %s with identity ‘%s’ in credentials",
id,
identity);
goto out;
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 9154c98..36beb38 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -725,7 +725,7 @@ get_ticket_sync (GoaKerberosProvider *self,
g_set_error (error,
GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Could not find saved credentials for principal `%s' in keyring"), identifier);
+ _("Could not find saved credentials for principal ‘%s’ in keyring"), identifier);
goto out;
}
@@ -735,7 +735,7 @@ get_ticket_sync (GoaKerberosProvider *self,
g_set_error (error,
GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Did not find password for principal `%s' in credentials"),
+ _("Did not find password for principal ‘%s’ in credentials"),
identifier);
goto out;
}
diff --git a/src/goabackend/goaoauth2provider.c b/src/goabackend/goaoauth2provider.c
index 138bde3..99c60a9 100644
--- a/src/goabackend/goaoauth2provider.c
+++ b/src/goabackend/goaoauth2provider.c
@@ -913,7 +913,7 @@ on_web_view_navigation_policy_decision_requested (WebKitWebView *web
g_set_error (&priv->error,
GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Authorization response was \"%s\""),
+ _("Authorization response was ‘%s’"),
(const gchar *) g_hash_table_lookup (key_value_pairs, "error"));
gtk_dialog_response (priv->dialog, GTK_RESPONSE_CLOSE);
}
@@ -953,7 +953,7 @@ on_web_view_navigation_policy_decision_requested (WebKitWebView *web
g_set_error (&priv->error,
GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Authorization response was \"%s\""),
+ _("Authorization response was ‘%s’"),
(const gchar *) g_hash_table_lookup (key_value_pairs, "error"));
gtk_dialog_response (priv->dialog, GTK_RESPONSE_CLOSE);
}
diff --git a/src/goabackend/goaowncloudprovider.c b/src/goabackend/goaowncloudprovider.c
index edb936f..db6eea3 100644
--- a/src/goabackend/goaowncloudprovider.c
+++ b/src/goabackend/goaowncloudprovider.c
@@ -400,7 +400,7 @@ ensure_credentials_sync (GoaProvider *provider,
{
*error = g_error_new (GOA_ERROR,
GOA_ERROR_NOT_AUTHORIZED,
- _("Did not find password with identity `%s' in credentials"),
+ _("Did not find password with identity ‘%s’ in credentials"),
username);
}
goto out;
@@ -423,7 +423,7 @@ ensure_credentials_sync (GoaProvider *provider,
* (eg., debarshi ray gmail com or rishi), and the
* (%s, %d) is the error domain and code.
*/
- _("Invalid password with username `%s' (%s, %d): "),
+ _("Invalid password with username ‘%s’ (%s, %d): "),
username,
g_quark_to_string ((*error)->domain),
(*error)->code);
@@ -1187,7 +1187,7 @@ on_handle_get_password (GoaPasswordBased *interface,
g_dbus_method_invocation_return_error (invocation,
GOA_ERROR,
GOA_ERROR_FAILED, /* TODO: more specific */
- _("Did not find password with identity `%s' in credentials"),
+ _("Did not find password with identity ‘%s’ in credentials"),
identity);
goto out;
}
diff --git a/src/goabackend/goautils.c b/src/goabackend/goautils.c
index 375df14..2d411ca 100644
--- a/src/goabackend/goautils.c
+++ b/src/goabackend/goautils.c
@@ -514,7 +514,7 @@ goa_utils_set_error_ssl (GError **err, GTlsCertificateFlags flags)
break;
case G_TLS_CERTIFICATE_NOT_ACTIVATED:
- error_msg = _("The certificate's activation time is still in the future.");
+ error_msg = _("The certificate’s activation time is still in the future.");
break;
case G_TLS_CERTIFICATE_EXPIRED:
@@ -526,7 +526,7 @@ goa_utils_set_error_ssl (GError **err, GTlsCertificateFlags flags)
break;
case G_TLS_CERTIFICATE_INSECURE:
- error_msg = _("The certificate's algorithm is considered insecure.");
+ error_msg = _("The certificate’s algorithm is considered insecure.");
break;
default:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
