[rygel] server: No OCM flags checking for CreateReference



commit faa7ec85a9832193ddab50a74ad986da8592b426
Author: Jens Georg <jensg openismus com>
Date:   Tue Sep 3 10:35:17 2013 +0200

    server: No OCM flags checking for CreateReference
    
    There's no DLNA guidelines for reference creation, however if a container only
    supports reference creation such as MediaExport's playlist containers, it
    mustn't have the UPLOAD OCM flag set.
    
    So we just check for writable container and let the creation fail later on in
    the container if it's not allowed to have references there.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707065

 src/librygel-server/rygel-reference-creator.vala |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/librygel-server/rygel-reference-creator.vala 
b/src/librygel-server/rygel-reference-creator.vala
index 93c06f9..b976dd9 100644
--- a/src/librygel-server/rygel-reference-creator.vala
+++ b/src/librygel-server/rygel-reference-creator.vala
@@ -111,8 +111,7 @@ internal class Rygel.ReferenceCreator : GLib.Object, Rygel.StateMachine {
         if (media_object == null || !(media_object is MediaContainer)) {
             throw new ContentDirectoryError.NO_SUCH_CONTAINER
                                         (_("No such object"));
-        } else if (!(OCMFlags.UPLOAD in media_object.ocm_flags) ||
-                   !(media_object is WritableContainer)) {
+        } else if (!(media_object is WritableContainer)) {
             throw new ContentDirectoryError.RESTRICTED_PARENT
                                         (_("Object creation in %s not allowed"),
                                          media_object.id);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]