[gnome-shell] overviewControls: Remove dead code



commit 1240d6be769f3791fa6933652bea259e6f05d4af
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Wed Sep 18 19:05:42 2013 -0400

    overviewControls: Remove dead code
    
    The parent SlidingControl had an onOverviewShowing, but we had
    overridden it with the same code in both subclasses. Just move it
    back to SlidingControl.

 js/ui/overviewControls.js |   19 ++-----------------
 1 files changed, 2 insertions(+), 17 deletions(-)
---
diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index 00007f2..fbf982f 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -168,11 +168,10 @@ const SlidingControl = new Lang.Class({
     },
 
     _onOverviewShowing: function() {
-        // reset any translation and make sure the actor is visible when
-        // entering the overview
         this.visible = true;
         this.layout.slideX = this.getSlide();
-        this.actor.translation_x = 0;
+        this.actor.translation_x = this._getTranslation();
+        this.slideIn();
     },
 
     _onWindowDragBegin: function() {
@@ -273,13 +272,6 @@ const ThumbnailsSlider = new Lang.Class({
         return alwaysZoomOut;
     },
 
-    _onOverviewShowing: function() {
-        this.visible = true;
-        this.layout.slideX = this.getSlide();
-        this.actor.translation_x = this._getTranslation();
-        this.slideIn();
-    },
-
     getNonExpandedWidth: function() {
         let child = this.actor.get_first_child();
         return child.get_theme_node().get_length('visible-width');
@@ -340,13 +332,6 @@ const DashSlider = new Lang.Class({
             return 0;
     },
 
-    _onOverviewShowing: function() {
-        this.visible = true;
-        this.layout.slideX = this.getSlide();
-        this.actor.translation_x = this._getTranslation();
-        this.slideIn();
-    },
-
     _onWindowDragBegin: function() {
         this.fadeHalf();
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]