[gnome-software] Do not try to set custom CSS when the application has no featured data
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Do not try to set custom CSS when the application has no featured data
- Date: Wed, 30 Oct 2013 09:34:26 +0000 (UTC)
commit 8f79f39463a81e1b6182476a3498ab8d9d8dfc95
Author: Richard Hughes <richard hughsie com>
Date: Wed Oct 30 09:12:35 2013 +0000
Do not try to set custom CSS when the application has no featured data
This is probably masking another bug somewhere, but at least now gnome-software
doesn't cause the CSS parser to explode.
src/gs-feature-tile.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/src/gs-feature-tile.c b/src/gs-feature-tile.c
index 1b2c07c..38a723a 100644
--- a/src/gs-feature-tile.c
+++ b/src/gs-feature-tile.c
@@ -97,6 +97,7 @@ void
gs_feature_tile_set_app (GsFeatureTile *tile, GsApp *app)
{
GsFeatureTilePrivate *priv;
+ const gchar *tmp;
gchar *data;
g_return_if_fail (GS_IS_FEATURE_TILE (tile));
@@ -118,6 +119,16 @@ gs_feature_tile_set_app (GsFeatureTile *tile, GsApp *app)
gtk_label_set_label (GTK_LABEL (priv->title), gs_app_get_name (app));
gtk_label_set_label (GTK_LABEL (priv->subtitle), gs_app_get_summary (app));
+
+ /* check the app has the featured data */
+ tmp = gs_app_get_metadata_item (app, "Featured::text-color");
+ if (tmp == NULL) {
+ data = gs_app_to_string (app);
+ g_warning ("%s has no featured data: %s",
+ gs_app_get_id (app), data);
+ goto out;
+ }
+
data = g_strdup_printf (
".button.featured-tile {\n"
" padding: 0;\n"
@@ -142,8 +153,8 @@ gs_feature_tile_set_app (GsFeatureTile *tile, GsApp *app)
gs_app_get_metadata_item (app, "Featured::text-color"),
gs_app_get_metadata_item (app, "Featured::background"),
gs_app_get_metadata_item (app, "Featured::background"));
-
gtk_css_provider_load_from_data (priv->provider, data, -1, NULL);
+out:
g_free (data);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]