[banshee] GStreamerSharp: remove superfluous state change events by PlayerEngine



commit 0354979d9f1d9d413968d5a68cf1850cc6aea0b3
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Tue Oct 29 15:56:00 2013 +0100

    GStreamerSharp: remove superfluous state change events by PlayerEngine
    
    While debugging GStreamerSharp backend, I noticed a sequence of events
    which was much more different to the usual one when using the GStreamer
    (unmanaged) backend. Instead of:
    
     Ready -> Idle -> Loading -> Loaded -> Playing
    
    I was seeing:
    
     Ready -> Idle -> Loading -> Playing -> Loaded -> Playing
    
    This was caused by useless events fired by the backend, which are not
    fired by the unmanaged GStreamer backend in its corresponding Play()
    and Pause() methods.
    
    This also made the process of adjusting the video window to the frame
    of NowPlaying source happen later, so it would cause an ugly effect on
    slow machines.

 .../Banshee.GStreamerSharp/PlayerEngine.cs         |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs 
b/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
index 7b89e72..9a9fa51 100644
--- a/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
+++ b/src/Backends/Banshee.GStreamerSharp/Banshee.GStreamerSharp/PlayerEngine.cs
@@ -741,13 +741,11 @@ namespace Banshee.GStreamerSharp
         public override void Play ()
         {
             playbin.SetState (Gst.State.Playing);
-            OnStateChanged (PlayerState.Playing);
         }
 
         public override void Pause ()
         {
             playbin.SetState (Gst.State.Paused);
-            OnStateChanged (PlayerState.Paused);
         }
 
         public override void Close (bool fullShutdown)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]