[gtk+/gtk-3-8] GtkModelMenu: don't leak submenus
- From: Lars Uebernickel <larsu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-8] GtkModelMenu: don't leak submenus
- Date: Fri, 25 Oct 2013 14:14:31 +0000 (UTC)
commit 37675d8227e1ada1c99e546d57b9e622bbda3d57
Author: Lars Uebernickel <lars uebernic de>
Date: Wed Oct 23 16:42:16 2013 -0400
GtkModelMenu: don't leak submenus
gtk_container_remove_child() is not enough to break the reference cycle
between the removed menu item and the submenu that is attached to it.
Use gtk_widget_destroy() instead.
https://bugzilla.gnome.org/show_bug.cgi?id=710754
gtk/gtkmodelmenu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtkmodelmenu.c b/gtk/gtkmodelmenu.c
index 0c3cc5e..af59a05 100644
--- a/gtk/gtkmodelmenu.c
+++ b/gtk/gtkmodelmenu.c
@@ -194,7 +194,7 @@ gtk_model_menu_binding_populate (GtkModelMenuBinding *binding)
children = gtk_container_get_children (GTK_CONTAINER (binding->shell));
while (children)
{
- gtk_container_remove (GTK_CONTAINER (binding->shell), children->data);
+ gtk_widget_destroy (children->data);
children = g_list_delete_link (children, children);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]