[banshee] libbanshee: remove obsolete comment about 'about-to-finish' hook
- From: Andrés Aragoneses <aaragoneses src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] libbanshee: remove obsolete comment about 'about-to-finish' hook
- Date: Thu, 24 Oct 2013 13:14:26 +0000 (UTC)
commit 7d91d546a6518321b0df39e8be0aea98be03be8a
Author: Andrés G. Aragoneses <knocte gmail com>
Date: Thu Oct 24 15:14:04 2013 +0200
libbanshee: remove obsolete comment about 'about-to-finish' hook
The callback attached to the 'about-to-finish' signal of Playbin served
two purposes some time ago:
a) Requesting the next track URI to banshee managed land.
b) Setting up a timeout to fire the OnNextTrackStarting callback some
moments after the about-to-finish signal was fired.
After this commit [1] from Christopher, the purpose (b) above was not
needed anymore because GStreamer would fire the event itself internally.
This change would render this comment *obsolete* (but Christopher probably
forgot to remove it) and *misleading*, the latter because the comment
only applied to the (b) purpose above, not (a). We still need to request
the next track URI to banshee's managed land, so the 'about-to-finish'
signal still needs to be used (contrary to what the comment seems to
suggest).
NOTE: Christopher's commit[1] hooked to the "playbin2-stream-changed"
event, but this has been deprecated in GStreamer in favour of the msg
type STREAM_START. More info here[2].
[1] https://git.gnome.org/browse/banshee/commit/?id=b1519fded83eab0f0d2dba821dcecf802f54490b
[2] https://git.gnome.org/browse/banshee/commit/?id=ea128c28c2fc167039cfbe1a8ae489c55fa55c0e
.../libbanshee/banshee-player-pipeline.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/src/Backends/Banshee.GStreamer/libbanshee/banshee-player-pipeline.c
b/src/Backends/Banshee.GStreamer/libbanshee/banshee-player-pipeline.c
index 4817887..5a6de49 100644
--- a/src/Backends/Banshee.GStreamer/libbanshee/banshee-player-pipeline.c
+++ b/src/Backends/Banshee.GStreamer/libbanshee/banshee-player-pipeline.c
@@ -291,9 +291,6 @@ _bp_pipeline_construct (BansheePlayer *player)
g_return_val_if_fail (player->playbin != NULL, FALSE);
- // FIXME: Connect a proxy about-to-finish callback that will generate a next-track-starting callback.
- // This can be removed once playbin generates its own next-track signal.
- // bgo#584987 - this is included in >= 0.10.26
g_signal_connect (player->playbin, "about-to-finish", G_CALLBACK (bp_about_to_finish_callback), player);
g_signal_connect (player->playbin, "notify::volume", G_CALLBACK (bp_volume_changed_callback), player);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]