[rhythmbox] metadata: complain a bit louder if the helper doesn't work



commit bfa8d37f7c10ad08b03ebcd02b99801a856fb6a7
Author: Jonathan Matthew <jonathan d14n org>
Date:   Tue Oct 22 23:14:28 2013 +1000

    metadata: complain a bit louder if the helper doesn't work
    
    If we were unable to spawn the metadata helper, things would just
    fail silently, and we'd also return while holding the metadata helper,
    so things would get even worse later on.

 metadata/rb-metadata-dbus-client.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/metadata/rb-metadata-dbus-client.c b/metadata/rb-metadata-dbus-client.c
index 7a73ad1..ed1bea5 100644
--- a/metadata/rb-metadata-dbus-client.c
+++ b/metadata/rb-metadata-dbus-client.c
@@ -615,6 +615,8 @@ rb_metadata_can_save (RBMetaData *md, const char *media_type)
 
        if (saveable_types == NULL) {
                if (start_metadata_service (&error) == FALSE) {
+                       g_warning ("unable to start metadata service: %s", error->message);
+                       g_static_mutex_unlock (&conn_mutex);
                        g_error_free (error);
                        return FALSE;
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]