[banshee] MediaPanelContents: Put the artist and album ListView in a Paned
- From: Bertrand Lorentz <blorentz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] MediaPanelContents: Put the artist and album ListView in a Paned
- Date: Sun, 20 Oct 2013 14:02:53 +0000 (UTC)
commit 4012eb854c6be5ab299f29a7fb8e56c18ec4f2e3
Author: Bertrand Lorentz <bertrand lorentz gmail com>
Date: Sun Oct 20 15:47:42 2013 +0200
MediaPanelContents: Put the artist and album ListView in a Paned
The ListView widget doesn't have a Gdk.Window of its own, it uses the
one of its parent. So, it seems that if 2 ListViews are put in the same
Gtk.Box, they end up sharing the same Gdk.Window. This has some unwanted
consequences, like mouse events not being handled at the right
coordinates. See bgo#710547.
So we put the artist and album ListView widgets in a Paned instead of a
Box, which gets us the right behavior. In addition, it make the division
between the two ListView adjustable, which is desirable in its own
right.
.../Banshee.MediaPanel/MediaPanelContents.cs | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/src/Extensions/Banshee.MediaPanel/Banshee.MediaPanel/MediaPanelContents.cs
b/src/Extensions/Banshee.MediaPanel/Banshee.MediaPanel/MediaPanelContents.cs
index 98d2ea2..0db88ef 100644
--- a/src/Extensions/Banshee.MediaPanel/Banshee.MediaPanel/MediaPanelContents.cs
+++ b/src/Extensions/Banshee.MediaPanel/Banshee.MediaPanel/MediaPanelContents.cs
@@ -128,17 +128,17 @@ namespace Banshee.MediaPanel
box.PackStartHighlighted (header, false, false, 0, HeaderBox.HighlightFlags.Background);
// Build the Library Views
- var views = new HBox () { Spacing = 5 };
- views.PackStart (SetupView (artist_view = new ArtistListView () {
+ var pane = new Paned (Orientation.Horizontal);
+ pane.Pack1 (SetupView (artist_view = new ArtistListView () {
Name = "media-panel-artists",
WidthRequest = 150,
DoNotRenderNullModel = true
- }), false, false, 0);
- views.PackStart (SetupView (album_view = new AlbumListView () {
- Name = "media-panel-albums",
- DoNotRenderNullModel = true
- }), true, true, 0);
- box.PackStart (views, true, true, 0);
+ }), false, false);
+ pane.Pack2 (SetupView (album_view = new AlbumListView () {
+ Name = "media-panel-albums",
+ DoNotRenderNullModel = true
+ }), true, true);
+ box.PackStart (pane, true, true, 0);
box.Hexpand = box.Vexpand = true;
box.Halign = box.Valign = Align.Fill;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]