[gnome-online-accounts] kerberos: correctly show sign in errors when mistyping password
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts] kerberos: correctly show sign in errors when mistyping password
- Date: Mon, 14 Oct 2013 18:08:49 +0000 (UTC)
commit 4ef715007e93ed8ebafde370cdb17daff49b1705
Author: Ray Strode <rstrode redhat com>
Date: Fri Oct 11 18:30:25 2013 -0400
kerberos: correctly show sign in errors when mistyping password
Right now if a user toggles the kerberos switch on, and then
mistypes their password, we pretend like everything succeeded.
This commit makes sure we report the failure and also makes sure
we show a Sign In button so the user can try again.
https://bugzilla.gnome.org/show_bug.cgi?id=709955
src/goabackend/goakerberosprovider.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 36beb38..07035bc 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -1885,7 +1885,11 @@ ensure_credentials_sync (GoaProvider *provider,
if (g_simple_async_result_propagate_error (operation_result, &lookup_error))
{
translate_error (&lookup_error);
- g_propagate_error (error, lookup_error);
+ g_set_error_literal (error,
+ GOA_ERROR,
+ GOA_ERROR_NOT_AUTHORIZED,
+ lookup_error->message);
+ g_error_free (lookup_error);
g_object_unref (operation_result);
return FALSE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]