[gnome-software] Correctly abort if PackageKit transactions fail
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Correctly abort if PackageKit transactions fail
- Date: Fri, 11 Oct 2013 10:56:39 +0000 (UTC)
commit 704b3071542e333c1e5a3e6f3055f1d59a6ef7da
Author: Richard Hughes <richard hughsie com>
Date: Fri Oct 11 10:26:20 2013 +0100
Correctly abort if PackageKit transactions fail
Otherwise we'll get critical warnings about re-using GErrors.
src/plugins/gs-plugin-packagekit-refine.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/src/plugins/gs-plugin-packagekit-refine.c b/src/plugins/gs-plugin-packagekit-refine.c
index 3055726..9507cdb 100644
--- a/src/plugins/gs-plugin-packagekit-refine.c
+++ b/src/plugins/gs-plugin-packagekit-refine.c
@@ -569,6 +569,8 @@ gs_plugin_refine (GsPlugin *plugin,
resolve_all,
cancellable,
error);
+ if (!ret)
+ goto out;
}
gs_profile_stop_full (plugin->profile, "packagekit-refine[name->id]");
@@ -608,6 +610,8 @@ gs_plugin_refine (GsPlugin *plugin,
updatedetails_all,
cancellable,
error);
+ if (!ret)
+ goto out;
}
gs_profile_stop_full (plugin->profile, "packagekit-refine[id->update-details]");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]