[pygobject] Add expected failure to deal with fixes in gimarshallingtests.c



commit 55d925d5f0fb87464b1f391c325c1e70da10d33d
Author: Simon Feltman <sfeltman src gnome org>
Date:   Thu Oct 10 16:10:16 2013 -0700

    Add expected failure to deal with fixes in gimarshallingtests.c
    
    Fix test_object_full_inout based on newer gimarshallingtests.c > 1.38.0.
    Add expectedFailure to deal with previous versions of gimarshallingtests.c.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709796

 tests/test_gi.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/tests/test_gi.py b/tests/test_gi.py
index 838cc89..ba2177f 100644
--- a/tests/test_gi.py
+++ b/tests/test_gi.py
@@ -1996,7 +1996,11 @@ class TestGObject(unittest.TestCase):
 
         GIMarshallingTests.Object.none_inout(GIMarshallingTests.SubObject(int=42))
 
+    @unittest.expectedFailure  # https://bugzilla.gnome.org/show_bug.cgi?id=709796
     def test_object_full_inout(self):
+        # Using gimarshallingtests.c from GI versions > 1.38.0 will show this
+        # test as an "unexpected success" due to reference leak fixes in that file.
+        # TODO: remove the expectedFailure once PyGI relies on GI > 1.38.0.
         object_ = GIMarshallingTests.Object(int=42)
         new_object = GIMarshallingTests.Object.full_inout(object_)
 
@@ -2004,7 +2008,7 @@ class TestGObject(unittest.TestCase):
 
         self.assertFalse(object_ is new_object)
 
-        self.assertEqual(object_.__grefcount__, 2)
+        self.assertEqual(object_.__grefcount__, 1)
         self.assertEqual(new_object.__grefcount__, 1)
 
 # FIXME: Doesn't actually return the same object.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]