[gnome-continuous] task: Don't bother reporting success/error in onEmpty
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-continuous] task: Don't bother reporting success/error in onEmpty
- Date: Wed, 9 Oct 2013 20:31:12 +0000 (UTC)
commit c87f945e0be4e42852046aed2138d1a666e5e34d
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Wed Oct 9 16:06:48 2013 -0400
task: Don't bother reporting success/error in onEmpty
It doesn't work anyway, and isn't really an API we can rely on.
src/js/builtins/make.js | 6 +-----
src/js/task.js | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/src/js/builtins/make.js b/src/js/builtins/make.js
index e1b6dc0..dbcf7e9 100644
--- a/src/js/builtins/make.js
+++ b/src/js/builtins/make.js
@@ -45,7 +45,6 @@ const Make = new Lang.Class({
this._loop = loop;
this._failed = false;
this._cancellable = cancellable;
- this._tasksComplete = false;
this._oneOnly = args.only;
let taskmaster = new Task.TaskMaster(this.workdir,
{ onEmpty: Lang.bind(this, this._onTasksComplete),
@@ -98,10 +97,7 @@ const Make = new Lang.Class({
}
},
- _onTasksComplete: function(success, err) {
- this._tasksComplete = true;
- if (!success)
- this._err = err;
+ _onTasksComplete: function() {
this._loop.quit();
}
});
diff --git a/src/js/task.js b/src/js/task.js
index 831ff2c..aa59e50 100644
--- a/src/js/task.js
+++ b/src/js/task.js
@@ -265,7 +265,7 @@ const TaskMaster = new Lang.Class({
if (this._executing.length == 0 &&
this._pendingTasksList.length == 0) {
if (this._onEmpty)
- this._onEmpty(true, null);
+ this._onEmpty();
return;
} else if (this._pendingTasksList.length == 0) {
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]