[gobject-introspection] tests: remove manual validation code
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gobject-introspection] tests: remove manual validation code
- Date: Wed, 9 Oct 2013 16:55:02 +0000 (UTC)
commit d3c6c1030faff6bb0172d530e2f30c9115c17bbb
Author: Dieter Verfaillie <dieterv optionexplicit be>
Date: Thu Jul 18 08:13:22 2013 +0200
tests: remove manual validation code
We're already validating input .xml files so no need
to duplicate this...
tests/scanner/annotationparser/test_parser.py | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/tests/scanner/annotationparser/test_parser.py b/tests/scanner/annotationparser/test_parser.py
index 2ebb6c2..50a4fcc 100644
--- a/tests/scanner/annotationparser/test_parser.py
+++ b/tests/scanner/annotationparser/test_parser.py
@@ -99,10 +99,7 @@ class TestCommentBlock(unittest.TestCase):
parsed += '<docblock>\n'
parsed += ' <identifier>\n'
- # An identifier name is always required, but we can't trust our
- # own parser to ensure this when testing so fall back to an empty
- # string when no name has been parsed...
- parsed += ' <name>%s</name>\n' % (docblock.name or '', )
+ parsed += ' <name>%s</name>\n' % (docblock.name, )
if docblock.options.values:
parsed += ' <annotations>\n'
for key, value in docblock.options.values:
@@ -195,7 +192,6 @@ class TestCommentBlock(unittest.TestCase):
if docblock.find(ns('{}identifier')) is not None:
expected += ' <identifier>\n'
- # Expecting an identifier name is required, don't bother checking if it's there or not
expected += ' <name>%s</name>\n' % (docblock.find(ns('{}identifier/{}name')).text, )
annotations = docblock.find(ns('{}identifier/{}annotations'))
if annotations is not None:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]