[gnome-control-center] wacom: Fix use after free



commit 297eb6cfbba15a8a152d0640943af0107262ac3f
Author: Bastien Nocera <hadess hadess net>
Date:   Tue Oct 8 18:59:22 2013 +0200

    wacom: Fix use after free
    
    Causing random values in the calibration data.

 panels/wacom/cc-wacom-page.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/panels/wacom/cc-wacom-page.c b/panels/wacom/cc-wacom-page.c
index c7840ab..6d73704 100644
--- a/panels/wacom/cc-wacom-page.c
+++ b/panels/wacom/cc-wacom-page.c
@@ -298,13 +298,13 @@ calibrate (CcWacomPage *page)
        tmp = g_malloc (ncal * sizeof (GVariant*));
        for (i = 0; i < ncal; i++)
                tmp[i] = g_variant_new_int32 (calibration[i]);
-       g_free (calibration);
 
        array = g_variant_new_array (G_VARIANT_TYPE_INT32, tmp, 4);
        g_settings_set_value (page->priv->wacom_settings, "area", array);
        g_free (tmp);
 
        run_calibration (page, old_calibration, calibration, monitor);
+       g_free (calibration);
        gtk_widget_set_sensitive (WID ("button-calibrate"), FALSE);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]