[network-manager-applet/th/ca_cert_ignore: 2/2] applet: remove wrong assert in eap_method_ca_cert_not_required_toggled



commit efef3713d25084eaf6d8f057ffea286a552f6db3
Author: Thomas Haller <thaller redhat com>
Date:   Mon Oct 7 17:47:04 2013 +0200

    applet: remove wrong assert in eap_method_ca_cert_not_required_toggled
    
    When during "Connect to Hidden Network" an eap dialog gets loaded, the
    ca_cert_ignore flag might be missing. Still the user can click on
    "Connect" which causes the hereby removed assert to fail.
    
    When the user clicks "Connect", eventually, fill_connection and
    eap_method_ca_cert_not_required_set will be called, which saves the flag
    in gsettings and makes it permanently.
    
    That means for an connection with no ca certificate and no ignore flag
    the following holds:
    
    - the user can connect to it, by clicking on it in the list of available
      wifi networks. No warning will be issued that it might be insecure.
    - the user can connect to it, by calling "Connect to Hidden Network". In
      this case, the flag will also be saved and the connection becomes
      trusted.
    
    Signed-off-by: Thomas Haller <thaller redhat com>

 src/wireless-security/eap-method.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/wireless-security/eap-method.c b/src/wireless-security/eap-method.c
index 3f17715..768cb2c 100644
--- a/src/wireless-security/eap-method.c
+++ b/src/wireless-security/eap-method.c
@@ -543,14 +543,9 @@ eap_method_ca_cert_ignore_set (EAPMethod *method,
                                gboolean ca_cert_error,
                                const char *id_ca_cert_is_not_required_checkbox)
 {
-       GtkWidget *widget;
        NMSetting8021x *s_8021x;
        gboolean ignore;
 
-       /* We don't really need the checkbox value here. Just assert that it is set as expected. */
-       widget = GTK_WIDGET (gtk_builder_get_object (method->builder, id_ca_cert_is_not_required_checkbox));
-       g_assert (widget && (ca_cert_error || !filename == gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON 
(widget))));
-
        s_8021x = nm_connection_get_setting_802_1x (connection);
        if (s_8021x) {
                ignore = !ca_cert_error && filename == NULL;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]