[gnome-online-accounts/gnome-3-10] identity: use g_hash_table_unref not g_clear_object



commit b572c61563ab61b77f3dcab994c09123f18ec680
Author: Ray Strode <rstrode redhat com>
Date:   Mon Sep 30 14:04:40 2013 -0400

    identity: use g_hash_table_unref not g_clear_object
    
    the identity service finalize function is using
    g_clear_object on hash tables, which is incorrect.
    
    This commit changes the g_clear_object calls to use
    g_clear_pointer and g_hash_table_unref instead.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709103

 src/goaidentity/goaidentityservice.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/goaidentity/goaidentityservice.c b/src/goaidentity/goaidentityservice.c
index c11ba3b..dce156d 100644
--- a/src/goaidentity/goaidentityservice.c
+++ b/src/goaidentity/goaidentityservice.c
@@ -694,8 +694,10 @@ goa_identity_service_finalize (GObject *object)
 
   g_clear_object (&self->priv->identity_manager);
   g_clear_object (&self->priv->object_manager_server);
-  g_clear_object (&self->priv->watched_client_connections);
-  g_clear_object (&self->priv->key_holders);
+  g_clear_pointer (&self->priv->watched_client_connections,
+                   (GDestroyNotify) g_hash_table_unref);
+  g_clear_pointer (&self->priv->key_holders,
+                   (GDestroyNotify) g_hash_table_unref);
 
   G_OBJECT_CLASS (goa_identity_service_parent_class)->finalize (object);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]