[totem] plugins: Remove ‘check-pylint’ as a prerequisite of ‘check’



commit bef67e38b1cbd4b1c388e66239362fec932c235d
Author: Philip Withnall <philip tecnocode co uk>
Date:   Tue Oct 1 01:26:57 2013 +0100

    plugins: Remove ‘check-pylint’ as a prerequisite of ‘check’
    
    pylint can be useful, but since the initial round of fixes it’s just been
    noise. Tools run by `make check` should be useful, not a hurdle.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275

 src/plugins/Makefile.plugins |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/plugins/Makefile.plugins b/src/plugins/Makefile.plugins
index 75a87ab..087c977 100644
--- a/src/plugins/Makefile.plugins
+++ b/src/plugins/Makefile.plugins
@@ -44,6 +44,8 @@ vala_plugin_cflags = \
 # Checking rules for Python plugins
 # Execute pylint on all the requisite files individually, returning non-zero
 # iff any of the calls to pylint returned non-zero.
+# Don't bother adding this as a prerequisite rule of 'check', since it can
+# easily cause spurious and painful distcheck failures.
 check-pylint: $(plugin_PYTHON)
 if ENABLE_PYTHON
        @exitstatus=0; \
@@ -58,6 +60,4 @@ if ENABLE_PYTHON
        exit $$exitstatus
 endif
 
-check: check-pylint
-
 .PHONY: check-pylint


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]