[orca] Ignore selection-changed events when the current item's selection is toggled via Space
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Ignore selection-changed events when the current item's selection is toggled via Space
- Date: Tue, 26 Nov 2013 14:07:05 +0000 (UTC)
commit 74efe64a1bed6c8dc97c962a9ae64126b2495f20
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Tue Nov 26 09:06:17 2013 -0500
Ignore selection-changed events when the current item's selection is toggled via Space
src/orca/scripts/default.py | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/default.py b/src/orca/scripts/default.py
index a4fed52..2073dc7 100644
--- a/src/orca/scripts/default.py
+++ b/src/orca/scripts/default.py
@@ -2369,6 +2369,15 @@ class Script(script.Script):
state = obj.getState()
if state.contains(pyatspi.STATE_MANAGES_DESCENDANTS):
return
+
+ # TODO - JD: We need to give more thought to where we look to this
+ # event and where we prefer object:state-changed:selected.
+
+ # If the current item's selection is toggled, we'll present that
+ # via the state-changed event.
+ keyString, mods = self.utilities.lastKeyAndModifiers()
+ if keyString == "space":
+ return
# Save the event source, if it is a menu or combo box. It will be
# useful for optimizing componentAtDesktopCoords in the case that
@@ -2378,8 +2387,6 @@ class Script(script.Script):
if obj.getRole() in (pyatspi.ROLE_COMBO_BOX, pyatspi.ROLE_MENU):
self.lastSelectedMenu = obj
- # TODO - JD: We need to give more thought to where we look to this
- # event and where we prefer object:state-changed:selected.
selectedChildren = self.utilities.selectedChildren(obj)
for child in selectedChildren:
if not self.utilities.isLayoutOnly(child):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]