[gnumeric] xlsx: plug leak.



commit 86a8ba19271df19a26a6253297aaa7e1569da3ca
Author: Morten Welinder <terra gnome org>
Date:   Thu Nov 21 09:46:42 2013 -0500

    xlsx: plug leak.

 NEWS                      |    2 +-
 plugins/excel/ChangeLog   |    5 +++++
 plugins/excel/xlsx-read.c |    1 +
 3 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/NEWS b/NEWS
index 4e9dbe9..ccd2f6b 100644
--- a/NEWS
+++ b/NEWS
@@ -14,7 +14,7 @@ Morten:
        * Improve accuracy of bessel functions with large non-integer alpha.
        * Improve accuracy of ACOTH.
        * Fix fuzzed file crash.  [#708091] [#712662] [#712685] [#712700]
-         [#712708] [#712772]
+         [#712708] [#712772] [#712788]
        * Restore sheet reordering by drag.
        * Fix BETA on win32.
        * Fix win32 registry initialization.
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 2ec5dec..5fccde0 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-21  Morten Welinder  <terra gnome org>
+
+       * xlsx-read.c (xlsx_file_open): A severely malformed document can
+       leave an expression in the state.  Free that.  Fixes #712788.
+
 2013-11-20  Morten Welinder  <terra gnome org>
 
        * ms-escher.c (ms_escher_get_data): Fix fuzzed file crash.  Fixes
diff --git a/plugins/excel/xlsx-read.c b/plugins/excel/xlsx-read.c
index 3080b38..4b5d99f 100644
--- a/plugins/excel/xlsx-read.c
+++ b/plugins/excel/xlsx-read.c
@@ -4845,6 +4845,7 @@ xlsx_file_open (G_GNUC_UNUSED GOFileOpener const *fo, GOIOContext *context,
        xlsx_style_array_free (state.table_styles);
        g_hash_table_destroy (state.theme_colors_by_name);
        value_release (state.val);
+       if (state.texpr) gnm_expr_top_unref (state.texpr);
 
        workbook_set_saveinfo (state.wb, GO_FILE_FL_AUTO,
                               go_file_saver_for_id ((state.version == ECMA_376_2006) ?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]