[evolution/gnome-3-10] Bug #711499 - Failed image download lefts opened file descriptor



commit d966ac91920cf0f65180230a6f8db8620e342183
Author: Milan Crha <mcrha redhat com>
Date:   Wed Nov 20 18:31:57 2013 +0100

    Bug #711499 - Failed image download lefts opened file descriptor

 mail/e-http-request.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/mail/e-http-request.c b/mail/e-http-request.c
index 996a993..8491f87 100644
--- a/mail/e-http-request.c
+++ b/mail/e-http-request.c
@@ -269,6 +269,7 @@ handle_http_request (GSimpleAsyncResult *res,
                        goto cleanup;
                } else {
                        d (printf ("Failed to load '%s' from cache.\n", uri));
+                       g_object_unref (stream);
                }
        }
 
@@ -368,7 +369,10 @@ handle_http_request (GSimpleAsyncResult *res,
                send_and_handle_redirection (session, message, NULL);
 
                if (!SOUP_STATUS_IS_SUCCESSFUL (message->status_code)) {
-                       g_warning ("Failed to request %s (code %d)", uri, message->status_code);
+                       g_debug ("Failed to request %s (code %d)", uri, message->status_code);
+                       g_object_unref (message);
+                       g_object_unref (session);
+                       g_main_context_unref (context);
                        goto cleanup;
                }
 
@@ -394,6 +398,9 @@ handle_http_request (GSimpleAsyncResult *res,
                                                "Failed to write data to cache stream: %s",
                                                error->message);
                                g_clear_error (&error);
+                               g_object_unref (message);
+                               g_object_unref (session);
+                               g_main_context_unref (context);
                                goto cleanup;
                        }
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]