[gnome-user-share] obex: Fix launch context leak
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-user-share] obex: Fix launch context leak
- Date: Fri, 15 Nov 2013 12:43:19 +0000 (UTC)
commit ca8bc28d88e6df93e57e3dc265564d3f959fa87d
Author: Bastien Nocera <hadess hadess net>
Date: Fri Nov 15 12:02:21 2013 +0100
obex: Fix launch context leak
And refactor the code a bit.
src/obexpush.c | 22 ++++++++++++----------
1 files changed, 12 insertions(+), 10 deletions(-)
---
diff --git a/src/obexpush.c b/src/obexpush.c
index c8974ab..f365855 100644
--- a/src/obexpush.c
+++ b/src/obexpush.c
@@ -85,23 +85,25 @@ notification_launch_action_on_file_cb (NotifyNotification *notification,
const char *action,
const char *file_uri)
{
- GdkDisplay *display;
- GAppLaunchContext *ctx;
- GTimeVal val;
-
g_assert (action != NULL);
- g_get_current_time (&val);
-
- display = gdk_display_get_default ();
- ctx = G_APP_LAUNCH_CONTEXT (gdk_display_get_app_launch_context (display));
- gdk_app_launch_context_set_timestamp (GDK_APP_LAUNCH_CONTEXT (ctx), val.tv_sec);
-
/* We launch the file viewer for the file */
if (g_str_equal (action, "display") != FALSE) {
+ GdkDisplay *display;
+ GAppLaunchContext *ctx;
+ GTimeVal val;
+
+ g_get_current_time (&val);
+
+ display = gdk_display_get_default ();
+ ctx = G_APP_LAUNCH_CONTEXT (gdk_display_get_app_launch_context (display));
+ gdk_app_launch_context_set_timestamp (GDK_APP_LAUNCH_CONTEXT (ctx), val.tv_sec);
+
if (g_app_info_launch_default_for_uri (file_uri, ctx, NULL) == FALSE) {
g_warning ("Failed to launch the file viewer\n");
}
+
+ g_object_unref (ctx);
}
/* we open the Downloads folder */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]