[telepathy-account-widgets] protocol: skip Haze's IRC implementation



commit 5ffbe06ad7e3b86ada3871be2c0ee79468f3656b
Author: Debarshi Ray <debarshir gnome org>
Date:   Thu Oct 31 19:31:33 2013 +0100

    protocol: skip Haze's IRC implementation
    
    Users should be using Idle for IRC, and not Haze. This is implicitly
    codified in the widgets array kept in tpaw-account-widget.c. Otherwise,
    if Idle is absent we would still be advertising IRC support in the UI,
    only to crash immediately afterwards.
    
    All said and done, it is saner to support one single implementation of
    a protocol.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711226

 tp-account-widgets/tpaw-protocol.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/tp-account-widgets/tpaw-protocol.c b/tp-account-widgets/tpaw-protocol.c
index 72c579f..e397377 100644
--- a/tp-account-widgets/tpaw-protocol.c
+++ b/tp-account-widgets/tpaw-protocol.c
@@ -371,6 +371,11 @@ add_cm (GetProtocolsData *data,
         continue;
 
       if (!tp_strdiff (cm_name, "haze") &&
+          !tp_strdiff (proto_name, "irc"))
+        /* Use Idle for IRC (bgo #711226) */
+        continue;
+
+      if (!tp_strdiff (cm_name, "haze") &&
           !tp_strdiff (proto_name, "sip"))
         /* Haze's SIP implementation is pretty useless (bgo #629736) */
         continue;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]