[orca] Try to minimize some of the excessive chattiness with Gecko radio buttons
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Try to minimize some of the excessive chattiness with Gecko radio buttons
- Date: Thu, 14 Nov 2013 05:16:06 +0000 (UTC)
commit d74be3354d2b6b840ced8a6f92be64489bb43a15
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Thu Nov 14 00:14:33 2013 -0500
Try to minimize some of the excessive chattiness with Gecko radio buttons
src/orca/scripts/toolkits/Gecko/script.py | 12 ------------
.../scripts/toolkits/Gecko/speech_generator.py | 6 ++++++
2 files changed, 6 insertions(+), 12 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Gecko/script.py b/src/orca/scripts/toolkits/Gecko/script.py
index 4e07c43..28b4008 100644
--- a/src/orca/scripts/toolkits/Gecko/script.py
+++ b/src/orca/scripts/toolkits/Gecko/script.py
@@ -3768,18 +3768,6 @@ class Script(default.Script):
if self.labelInference.infer(prevObj) == string.strip():
continue
- # The radio button's label gets added to the context in
- # default.locusOfFocusChanged() and not through the speech
- # generator -- unless we wind up having to infer the label.
- # Therefore, if we have a valid label for a radio button,
- # we need to add it here.
- #
- if (role == pyatspi.ROLE_RADIO_BUTTON) \
- and not self.isAriaWidget(obj):
- label = self.utilities.displayedLabel(obj)
- if label:
- utterances.append([label, self.getACSS(obj, label)])
-
# If we don't have a string, then use the speech generator.
# Otherwise, we'll want to speak the string and possibly the
# role.
diff --git a/src/orca/scripts/toolkits/Gecko/speech_generator.py
b/src/orca/scripts/toolkits/Gecko/speech_generator.py
index 6d2a792..2459f28 100644
--- a/src/orca/scripts/toolkits/Gecko/speech_generator.py
+++ b/src/orca/scripts/toolkits/Gecko/speech_generator.py
@@ -523,3 +523,9 @@ class SpeechGenerator(speech_generator.SpeechGenerator):
else:
return speech_generator.SpeechGenerator._generatePositionInList(
self, obj, **args)
+
+ def _generateNewRadioButtonGroup(self, obj, **args):
+ # TODO - JD: Looking at the default speech generator's method, this
+ # is all kinds of broken. Until that can be sorted out, try to filter
+ # out some of the noise....
+ return []
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]