[gedit-code-assistance] Do not SEGV when proxy is updated



commit 1f70be60b00c46c0e0e40640afa950aec8a88918
Author: Jesse van den Kieboom <jessevdk gmail com>
Date:   Tue Nov 12 20:11:06 2013 +0100

    Do not SEGV when proxy is updated

 src/gca-diagnostics.vala |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)
---
diff --git a/src/gca-diagnostics.vala b/src/gca-diagnostics.vala
index 4bb5a57..8145684 100644
--- a/src/gca-diagnostics.vala
+++ b/src/gca-diagnostics.vala
@@ -66,11 +66,17 @@ class DiagnosticService : RemoteService, Object
 
        private void update_proxy()
        {
-               d_proxy.diagnostics.begin((obj, res) => {
+               var proxy = d_proxy;
+
+               proxy.diagnostics.begin((obj, res) => {
                        try
                        {
-                               var ret = d_proxy.diagnostics.end(res);
-                               d_diagnostics.update(transform(ret));
+                               var ret = proxy.diagnostics.end(res);
+
+                               if (proxy == d_proxy)
+                               {
+                                       d_diagnostics.update(transform(ret));
+                               }
                        }
                        catch (Error e)
                        {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]