[glom] Update some comments about bugs.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] Update some comments about bugs.
- Date: Fri, 8 Nov 2013 08:48:48 +0000 (UTC)
commit 64c5a57d70b0c448354529b25acde263f0c5538a
Author: Murray Cumming <murrayc murrayc com>
Date: Fri Nov 8 09:26:38 2013 +0100
Update some comments about bugs.
glom/libglom/data_structure/field.cc | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
---
diff --git a/glom/libglom/data_structure/field.cc b/glom/libglom/data_structure/field.cc
index 927fb6f..f0e7984 100644
--- a/glom/libglom/data_structure/field.cc
+++ b/glom/libglom/data_structure/field.cc
@@ -249,8 +249,7 @@ Glib::ustring Field::sql(const Gnome::Gda::Value& value, const Glib::RefPtr<Gnom
provider->get_data_handler_g_type(connection, gda_type);
if(datahandler)
{
- //Note that this does seems to add the needed quotes too, for instance around strings,
- //though that is not clearly documented. See bug http://bugzilla.gnome.org/show_bug.cgi?id=572220
+ //This is documented as adding the necessary quotes.
return datahandler->get_sql_from_value(value);
}
else
@@ -330,14 +329,9 @@ Glib::ustring Field::to_file_format(const Gnome::Gda::Value& value, glom_field_t
//Correction for text representations of image (binary) data:
//Avoid arbitrary newlines in this text.
//See libgda bug: https://bugzilla.gnome.org/show_bug.cgi?id=597390
+ //though that libgda behaviour will not be changed.
result = Utils::string_replace(result, "\n", "\\012");
-
- //Avoid arbitrary newlines in this text.
- //See libgda bug: https://bugzilla.gnome.org/show_bug.cgi?id=597390
result = Utils::string_replace(result, "\r", "\\015");
-
- //Escape any quotes in this text:
- //See libgda bug: https://bugzilla.gnome.org/show_bug.cgi?id=597390
return Utils::string_replace(result, "\"", "\\042");
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]