[gnome-shell] app-system: Don't use gmenu_tree_entry_get_desktop_app_info



commit 76eca409a3d79a02c05ce8c2d8341ec6a1961838
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Wed Oct 2 18:22:07 2013 -0400

    app-system: Don't use gmenu_tree_entry_get_desktop_app_info
    
    It's a broken method when it comes to giving us a useful GDesktopAppInfo,
    and it's hard to fix libgmenu properly, so simply recreate the app info
    using the desktop file ID that libgmenu has.

 src/shell-app-system.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/shell-app-system.c b/src/shell-app-system.c
index 8d36f25..a825712 100644
--- a/src/shell-app-system.c
+++ b/src/shell-app-system.c
@@ -341,7 +341,7 @@ on_apps_tree_changed_cb (GMenuTree *tree,
       else
         g_free (prefix);
 
-      info = gmenu_tree_entry_get_app_info (entry);
+      info = g_desktop_app_info_new (gmenu_tree_entry_get_desktop_file_id (entry));
 
       app = g_hash_table_lookup (self->priv->id_to_app, id);
       if (app != NULL)
@@ -363,6 +363,8 @@ on_apps_tree_changed_cb (GMenuTree *tree,
           app = _shell_app_new (info);
         }
 
+      g_object_unref (info);
+
       g_hash_table_replace (self->priv->id_to_app, (char*)id, app);
       if (!gmenu_tree_entry_get_is_nodisplay_recurse (entry))
         g_hash_table_replace (self->priv->visible_id_to_app, (char*)id, app);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]