[extensions-web] Use django.shortcuts.render by default
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] Use django.shortcuts.render by default
- Date: Tue, 28 May 2013 23:05:13 +0000 (UTC)
commit b2d93151a430f32d16f8758b87a4b729c7f3d80b
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Mon May 20 17:13:14 2013 -0400
Use django.shortcuts.render by default
Now that we can rely on Django 1.4, we can put this here.
sweettooth/auth/views.py | 3 +--
sweettooth/errorreports/views.py | 3 +--
sweettooth/extensions/views.py | 3 +--
sweettooth/review/views.py | 3 +--
sweettooth/utils.py | 6 ------
5 files changed, 4 insertions(+), 14 deletions(-)
---
diff --git a/sweettooth/auth/views.py b/sweettooth/auth/views.py
index 55700fe..4ba40f2 100644
--- a/sweettooth/auth/views.py
+++ b/sweettooth/auth/views.py
@@ -2,14 +2,13 @@
from django.contrib.auth import models
from django.contrib.auth.decorators import login_required
from django.http import HttpResponseForbidden
-from django.shortcuts import get_object_or_404, redirect
+from django.shortcuts import get_object_or_404, redirect, render
from django.views.decorators.http import require_POST
from review.models import CodeReview
from extensions.models import Extension, ExtensionVersion
from decorators import ajax_view
-from utils import render
def profile(request, user):
userobj = get_object_or_404(models.User, username=user)
diff --git a/sweettooth/errorreports/views.py b/sweettooth/errorreports/views.py
index d2a17a7..188d4e5 100644
--- a/sweettooth/errorreports/views.py
+++ b/sweettooth/errorreports/views.py
@@ -4,7 +4,7 @@ from django.contrib import messages
from django.core.mail import send_mail
from django.core.urlresolvers import reverse
from django.http import HttpResponseForbidden
-from django.shortcuts import redirect
+from django.shortcuts import redirect, render
from django.template import Context
from django.template.loader import render_to_string
@@ -13,7 +13,6 @@ from errorreports.forms import ErrorReportForm
from extensions.models import Extension
from decorators import model_view
-from utils import render
@model_view(Extension.objects.visible())
def report_error(request, extension):
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index b366d89..26f60e1 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -9,7 +9,7 @@ from django.contrib.auth.decorators import login_required
from django.contrib import messages
from django.db import transaction
from django.http import HttpResponseForbidden, HttpResponseServerError, Http404
-from django.shortcuts import get_object_or_404, redirect
+from django.shortcuts import get_object_or_404, redirect, render
from django.template.loader import render_to_string
from django.views.decorators.http import require_POST
@@ -17,7 +17,6 @@ from extensions import models, search
from extensions.forms import UploadForm
from decorators import ajax_view, model_view
-from utils import render
def get_versions_for_version_strings(version_strings):
def get_version(major, minor, point):
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index 9795bf0..aeaa674 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -11,7 +11,7 @@ import pygments.formatters
from django.core.mail import EmailMessage
from django.core.urlresolvers import reverse
from django.http import HttpResponseForbidden, Http404
-from django.shortcuts import redirect, get_object_or_404
+from django.shortcuts import redirect, get_object_or_404, render
from django.template import Context
from django.template.loader import render_to_string
from django.views.decorators.http import require_POST
@@ -21,7 +21,6 @@ from review.models import CodeReview, get_all_reviewers
from extensions import models
from decorators import ajax_view, model_view
-from utils import render
IMAGE_TYPES = {
'.png': 'image/png',
diff --git a/sweettooth/utils.py b/sweettooth/utils.py
index bf7fa1f..cb69266 100644
--- a/sweettooth/utils.py
+++ b/sweettooth/utils.py
@@ -2,12 +2,6 @@
import urllib
import hashlib
-from django.shortcuts import render_to_response
-from django.template import RequestContext
-
-def render(req, *args, **kwargs):
- return render_to_response(context_instance=RequestContext(req), *args, **kwargs)
-
GRAVATAR_BASE = "https://secure.gravatar.com/avatar/%s?%s"
def gravatar_url(request, email, size=70):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]