[gnumeric] Use ctrl-a only to select the whole sheet, if the sheet has focus. [#699746]



commit fe9265b1aa7b4a6f8b67bd68c657db0d65a15dd4
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Mon May 27 16:18:23 2013 -0600

    Use ctrl-a only to select the whole sheet, if the sheet has focus. [#699746]
    
    2013-05-27  Andreas J. Guelzow <aguelzow pyrshep ca>
    
        * component/Gnumeric-embed.xml.in: ctrl-a will be handled in gnm-pane.c
        * src/GNOME_Gnumeric-gtk.xml.in: ctrl-a will be handled in gnm-pane.c
        * src/wbc-gtk-actions.c: ctrl-a will be handled in gnm-pane.c
        * src/gnm-pane.c (gnm_pane_key_mode_sheet): recognize and handle ctrl-a

 ChangeLog                       |    7 +++++++
 NEWS                            |    1 +
 component/Gnumeric-embed.xml.in |    1 -
 src/GNOME_Gnumeric-gtk.xml.in   |    1 -
 src/gnm-pane.c                  |    3 +++
 src/wbc-gtk-actions.c           |    4 ----
 6 files changed, 11 insertions(+), 6 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 2fd8c1e..b4a126c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2013-05-27  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+       * component/Gnumeric-embed.xml.in: ctrl-a will be handled in gnm-pane.c
+       * src/GNOME_Gnumeric-gtk.xml.in: ctrl-a will be handled in gnm-pane.c
+       * src/wbc-gtk-actions.c: ctrl-a will be handled in gnm-pane.c
+       * src/gnm-pane.c (gnm_pane_key_mode_sheet): recognize and handle ctrl-a
+
 2013-05-26  Andreas J. Guelzow <aguelzow pyrshep ca>
 
        * src/item-grid.c (item_grid_button_pressed): make buttons 1 and 2
diff --git a/NEWS b/NEWS
index d7f5544..bed09fe 100644
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,7 @@ Andreas:
        * Do not include hidden cells in automatic print range. [#700994]
        * Make buttons 1 and 2 behave similarly when selecting cells. [#700792]
        * Warn when encountering extLst in xlsx import. [#700018]
+       * Use ctrl-a only to select the whole sheet, if the sheet has focus. [#699746]
 
 Darrell Tangman:
        * Update documentation for Edit and Insert menus. [#700596]
diff --git a/component/Gnumeric-embed.xml.in b/component/Gnumeric-embed.xml.in
index 67f5537..8461e92 100644
--- a/component/Gnumeric-embed.xml.in
+++ b/component/Gnumeric-embed.xml.in
@@ -416,7 +416,6 @@
   <accelerator name="FormatAddBorders"  action="FormatAddBorders"/>
   <accelerator name="FormatClearBorders" action="FormatClearBorders"/>
   <accelerator name="Repeat"            action="Repeat"/>
-  <accelerator name="EditSelectAllXL"   action="EditSelectAllXL"/>
   <accelerator name="EditDeleteCellsXL"         action="EditDeleteCellsXL"/>
   <accelerator name="InsertCellsXL"     action="InsertCellsXL"/>
 </ui>
diff --git a/src/GNOME_Gnumeric-gtk.xml.in b/src/GNOME_Gnumeric-gtk.xml.in
index ddc27ff..b7f0e59 100644
--- a/src/GNOME_Gnumeric-gtk.xml.in
+++ b/src/GNOME_Gnumeric-gtk.xml.in
@@ -422,7 +422,6 @@
   <accelerator name="FormatAddBorders"  action="FormatAddBorders"/>
   <accelerator name="FormatClearBorders" action="FormatClearBorders"/>
   <accelerator name="Repeat"            action="Repeat"/>
-  <accelerator name="EditSelectAllXL"   action="EditSelectAllXL"/>
   <accelerator name="EditDeleteCellsXL"         action="EditDeleteCellsXL"/>
   <accelerator name="InsertCellsXL"     action="InsertCellsXL"/>
 </ui>
diff --git a/src/gnm-pane.c b/src/gnm-pane.c
index 1610f86..2605a52 100644
--- a/src/gnm-pane.c
+++ b/src/gnm-pane.c
@@ -175,6 +175,9 @@ gnm_pane_key_mode_sheet (GnmPane *pane, GdkEventKey *event,
                        : scg_cursor_move;
 
        switch (event->keyval) {
+       case GDK_KEY_a:
+               scg_select_all (scg);
+               break;
        case GDK_KEY_KP_Left:
        case GDK_KEY_Left:
                if (event->state & GDK_MOD1_MASK)
diff --git a/src/wbc-gtk-actions.c b/src/wbc-gtk-actions.c
index ffbf03c..8e07141 100644
--- a/src/wbc-gtk-actions.c
+++ b/src/wbc-gtk-actions.c
@@ -2223,10 +2223,6 @@ static GtkActionEntry const actions[] = {
        { "EditSelectAll", NULL, N_("_All"),
                "<control><shift>space", N_("Select all cells in the spreadsheet"),
                G_CALLBACK (cb_edit_select_all) },
-       /* A duplicate that should not go into the menus, used only for the accelerator */
-       { "EditSelectAllXL", NULL, N_("_All"),
-               "<control>a", N_("Select all cells in the spreadsheet"),
-               G_CALLBACK (cb_edit_select_all) },
        { "EditSelectColumn", NULL, N_("_Column"),
                "<control>space", N_("Select an entire column"),
                G_CALLBACK (cb_edit_select_col) },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]