[gnumeric] Style: fix critical.



commit ec4d966a75ed6d618600b869d4e2d5024a07ca47
Author: Morten Welinder <terra gnome org>
Date:   Thu May 23 19:39:35 2013 -0400

    Style: fix critical.

 ChangeLog         |    4 ++++
 NEWS              |    1 +
 src/sheet-style.c |    6 +++++-
 3 files changed, 10 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 3b8fac0..1eabf40 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-05-23  Morten Welinder  <terra gnome org>
+
+       * src/sheet-style.c (internal_style_list): Fix critical.
+
 2013-05-22  Morten Welinder  <terra gnome org>
 
        * src/mathfunc.c (R_ptukey): Even more C, even less Fortran.
diff --git a/NEWS b/NEWS
index 1c8c4ac..94ee0d4 100644
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,7 @@ Morten:
        * Add new R.PTUKEY function.  [#700132]
        * Fix missing translation of certain function examples.
        * Add new R.PNORM2 function.
+       * Fix critical when last row deleted.
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.2
diff --git a/src/sheet-style.c b/src/sheet-style.c
index e82f82d..0575e2b 100644
--- a/src/sheet-style.c
+++ b/src/sheet-style.c
@@ -2801,7 +2801,11 @@ internal_style_list (Sheet const *sheet, GnmRange const *r,
 
        g_return_val_if_fail (IS_SHEET (sheet), NULL);
 
-       if (!r)
+       if (r) {
+               /* This can happen if the last row or column is deleted.  */
+               if (!range_valid (r))
+                       return NULL;
+       } else
                r = range_init_full_sheet (&full_sheet, sheet);
 
        data.accum = g_ptr_array_new ();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]