[gnome-shell] layout: Remove affectsInputRegion
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] layout: Remove affectsInputRegion
- Date: Wed, 22 May 2013 16:11:40 +0000 (UTC)
commit e62d22a50ed8aa25de988fb3c389b999e42f2eac
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Sat May 18 20:59:46 2013 -0400
layout: Remove affectsInputRegion
This can easy be worked around by adding things to the uiGroup
instead, so there's really no reason to have it here still.
https://bugzilla.gnome.org/show_bug.cgi?id=700735
js/ui/layout.js | 14 ++++++--------
js/ui/osdWindow.js | 2 +-
2 files changed, 7 insertions(+), 9 deletions(-)
---
diff --git a/js/ui/layout.js b/js/ui/layout.js
index 0d339d9..bf9edbd 100644
--- a/js/ui/layout.js
+++ b/js/ui/layout.js
@@ -137,7 +137,6 @@ const Monitor = new Lang.Class({
const defaultParams = {
trackFullscreen: false,
affectsStruts: false,
- affectsInputRegion: true
};
const LayoutManager = new Lang.Class({
@@ -732,11 +731,10 @@ const LayoutManager = new Lang.Class({
// @actor: an actor to add to the chrome
// @params: (optional) additional params
//
- // Adds @actor to the chrome, and (unless %affectsInputRegion in
- // @params is %false) extends the input region to include it.
- // Changes in @actor's size, position, and visibility will
- // automatically result in appropriate changes to the input
- // region.
+ // Adds @actor to the chrome, and extends the input region
+ // to include it. Changes in @actor's size, position, and
+ // visibility will automatically result in appropriate changes
+ // to the input region.
//
// If %affectsStruts in @params is %true (and @actor is along a
// screen edge), then @actor's size and position will also affect
@@ -950,7 +948,7 @@ const LayoutManager = new Lang.Class({
for (i = 0; i < this._trackedActors.length; i++) {
let actorData = this._trackedActors[i];
- if (!(actorData.affectsInputRegion && wantsInputRegion) && !actorData.affectsStruts)
+ if (!wantsInputRegion && !actorData.affectsStruts)
continue;
let [x, y] = actorData.actor.get_transformed_position();
@@ -960,7 +958,7 @@ const LayoutManager = new Lang.Class({
w = Math.round(w);
h = Math.round(h);
- if (actorData.affectsInputRegion && wantsInputRegion && actorData.actor.get_paint_visibility())
+ if (wantsInputRegion && actorData.actor.get_paint_visibility())
rects.push(new Meta.Rectangle({ x: x, y: y, width: w, height: h }));
if (actorData.affectsStruts) {
diff --git a/js/ui/osdWindow.js b/js/ui/osdWindow.js
index bab721d..b0a70e1 100644
--- a/js/ui/osdWindow.js
+++ b/js/ui/osdWindow.js
@@ -107,7 +107,7 @@ const OsdWindow = new Lang.Class({
Lang.bind(this, this._monitorsChanged));
this._monitorsChanged();
- Main.layoutManager.addChrome(this.actor, { affectsInputRegion: false });
+ Main.uiGroup.add_child(this.actor);
},
setIcon: function(icon) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]