[gnome-shell] messageTray: Clean up variable names
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] messageTray: Clean up variable names
- Date: Mon, 20 May 2013 17:40:42 +0000 (UTC)
commit 176a73f4e919afbd2fee544ff8812ae996d10208
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Wed Jan 2 07:56:07 2013 -0500
messageTray: Clean up variable names
Variable names like "sourceNotificationStackDoneShowing" are too
long, and too undescriptive: this one points to a source, not a
notification stack that has been done showing.
js/ui/messageTray.js | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 64fcecf..635ee26 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2768,17 +2768,14 @@ const MessageTray = new Lang.Class({
this._summaryBoxPointerState = State.HIDDEN;
this._summaryBoxPointer.bin.child = null;
- let sourceNotificationStackDoneShowing = null;
if (doneShowingNotificationStack) {
- this._summaryBoxPointerItem.doneShowingNotificationStack();
- sourceNotificationStackDoneShowing = this._summaryBoxPointerItem.source;
- }
+ let source = this._summaryBoxPointerItem.source;
- this._summaryBoxPointerItem = null;
+ this._summaryBoxPointerItem.doneShowingNotificationStack();
+ this._summaryBoxPointerItem = null;
- if (sourceNotificationStackDoneShowing) {
- if (sourceNotificationStackDoneShowing.isTransient && !this._reNotifyAfterHideNotification)
- sourceNotificationStackDoneShowing.destroy(NotificationDestroyedReason.EXPIRED);
+ if (source.isTransient && !this._reNotifyAfterHideNotification)
+ source.destroy(NotificationDestroyedReason.EXPIRED);
if (this._reNotifyAfterHideNotification) {
this._onNotify(this._reNotifyAfterHideNotification.source,
this._reNotifyAfterHideNotification);
this._reNotifyAfterHideNotification = null;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]