[gnome-shell] ScreenShield: mark music notifications as acknowledged immediately
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] ScreenShield: mark music notifications as acknowledged immediately
- Date: Sun, 12 May 2013 18:19:26 +0000 (UTC)
commit 2591bc90ac90add209736b21be18c20f6cea9814
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Sun May 12 19:42:49 2013 +0200
ScreenShield: mark music notifications as acknowledged immediately
After all, the user is seeing it (or will see them before unlocking),
so there is no point in queing them as banners.
https://bugzilla.gnome.org/show_bug.cgi?id=698812
js/ui/screenShield.js | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
index 5b3ed95..cfd55b9 100644
--- a/js/ui/screenShield.js
+++ b/js/ui/screenShield.js
@@ -214,6 +214,7 @@ const NotificationsBox = new Lang.Class({
if (musicNotification != null &&
this._musicBin.child == null) {
+ musicNotification.acknowledged = true;
if (musicNotification.actor.get_parent() != null)
musicNotification.actor.get_parent().remove_actor(musicNotification.actor);
this._musicBin.child = musicNotification.actor;
@@ -246,6 +247,7 @@ const NotificationsBox = new Lang.Class({
sourceCountChangedId: 0,
sourceTitleChangedId: 0,
sourceUpdatedId: 0,
+ sourceNotifyId: 0,
musicNotification: null,
sourceBox: null,
titleLabel: null,
@@ -256,6 +258,12 @@ const NotificationsBox = new Lang.Class({
this._showSource(source, obj, obj.sourceBox);
this._notificationBox.add(obj.sourceBox, { x_fill: false, x_align: St.Align.START });
+ if (obj.musicNotification) {
+ obj.sourceNotifyId = source.connect('notify', Lang.bind(this, function(source, notification) {
+ notification.acknowledged = true;
+ }));
+ }
+
obj.sourceCountChangedId = source.connect('count-updated', Lang.bind(this, function(source) {
this._countChanged(source, obj);
}));
@@ -336,6 +344,8 @@ const NotificationsBox = new Lang.Class({
if (obj.musicNotification) {
this._musicBin.child = null;
obj.musicNotification = null;
+
+ source.disconnect(obj.sourceNotifyId);
}
source.disconnect(obj.sourceDestroyId);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]