[evolution-ews] Fix bogus GError handling in ews_gal_needs_update() causing false negatives



commit 9dc92bbf668ef4261cc7de2bb5e3c0e0b01aa47e
Author: David Woodhouse <David Woodhouse intel com>
Date:   Wed May 1 11:37:20 2013 +0100

    Fix bogus GError handling in ews_gal_needs_update() causing false negatives

 src/addressbook/e-book-backend-ews.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/addressbook/e-book-backend-ews.c b/src/addressbook/e-book-backend-ews.c
index bdd4065..930182b 100644
--- a/src/addressbook/e-book-backend-ews.c
+++ b/src/addressbook/e-book-backend-ews.c
@@ -2039,14 +2039,15 @@ ews_gal_needs_update (EBookBackendEws *cbews,
                return FALSE;
 
        tmp = e_book_backend_sqlitedb_get_key_value (priv->summary, priv->folder_id, "seq", error);
-       if (error)
+       if (!tmp)
                goto exit;
 
        sscanf (tmp, "%"G_GUINT32_FORMAT, &seq);
        if (seq < full->seq)
                ret = TRUE;
 
-       d (printf ("Gal needs update: %d \n", ret);)
+       d (printf ("Gal needs update: %d (local: %d, remote: %d)\n",
+                  ret, seq, full->seq);)
 exit:
        g_free (tmp);
        return ret;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]