[rhythmbox] playbin: horrible hack to fix incorrect ref counting somewhere



commit 9dbe98cfe8ac548dbb2052babd6594642931a7bc
Author: Jonathan Matthew <jonathan d14n org>
Date:   Mon Mar 18 22:25:26 2013 +1000

    playbin: horrible hack to fix incorrect ref counting somewhere
    
    There's an extra unref somewhere between here and the replaygain
    plugin.  This hack stops us crashing until I can figure out where
    it is.  Since there's only ever one playbin instance it doesn't
    matter so much if its refcount is too high.

 backends/gstreamer/rb-player-gst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index 16242f6..a305d1a 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -1062,7 +1062,7 @@ impl_get_property (GObject *object,
 
        switch (prop_id) {
        case PROP_PLAYBIN:
-               g_value_set_object (value, mp->priv->playbin);
+               g_value_set_object (value, mp->priv->playbin ? g_object_ref (mp->priv->playbin) : NULL);
                break;
        case PROP_BUS:
                if (mp->priv->playbin) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]