[gnome-boxes] vm-configurator: Disable SPICE image compression
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] vm-configurator: Disable SPICE image compression
- Date: Mon, 18 Mar 2013 22:04:25 +0000 (UTC)
commit 8a24b9d25aa286f0a57ec6dd0accece3a82408cd
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Sat Mar 9 16:45:59 2013 +0200
vm-configurator: Disable SPICE image compression
Since the VMs we create are by default local-only and SPICE server is
tied to localhost, it makes a lot of sense to disable image compression
as that wastes a lot CPU/battery for no good reason.
This patch makes gnome-shell's animations inside VM a lot more smooth. On
my system, it actually now feels very much native.
Alex pointed out that doing this implies disabling streaming as well,
which is not a problem on its own and we probably should be disabling
that explicitly as well but unfortunately streaming is required for
lipsync in SPICE.
However, in practice I see no evidence of lipsync happening anyways. I
tested this by playing a high definition (1920x1080) video[1] in
fullscreen on different guest OSs (Fedora, Ubuntu, Windows XP and
Windows 7) with and without SPICE compression enabled. On all OSs except
for Ubuntu, I actually saw improvements in video playback performance,
even w.r.t lipsync with compression disabled. On Ubuntu, there were just
no significant difference for some reason.
Ideally SPICE should probably itself take care of disabling compression
for local-only case[2] and decouple streaming from image compression[3]
but for now its probably a good idea to disable compression ourselves.
[1] http://www.bigbuckbunny.org/index.php/download/
[2] https://bugs.freedesktop.org/show_bug.cgi?id=62188
[3] https://bugs.freedesktop.org/show_bug.cgi?id=62187
https://bugzilla.gnome.org/show_bug.cgi?id=695492
src/vm-configurator.vala | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/vm-configurator.vala b/src/vm-configurator.vala
index 6ab335b..8e8cc67 100644
--- a/src/vm-configurator.vala
+++ b/src/vm-configurator.vala
@@ -65,6 +65,7 @@ private class Boxes.VMConfigurator {
var graphics = new DomainGraphicsSpice ();
graphics.set_autoport (true);
+ graphics.set_image_compression (DomainGraphicsSpiceImageCompression.OFF);
domain.add_device (graphics);
// SPICE agent channel. This is needed for features like copy&paste between host and guest etc to
work.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]